Skip to content

Commit d481db6

Browse files
authored
Fix 4.0 domain status due to changes in operator 4.0 (#181)
* Fix due to changes in operator 4.0 for domain status no longer have intropectorJobFailureCount and missing available condtion failure reason. * Fix refactoring error * per change request
1 parent 0a89fd9 commit d481db6

File tree

4 files changed

+31
-5
lines changed

4 files changed

+31
-5
lines changed

electron/app/locales/en/webui.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -597,6 +597,7 @@
597597
"domain-design-domain-status-title": "Domain Status",
598598
"domain-design-domain-status-overallstatus": "Domain Status:",
599599
"domain-design-domain-status-introspectJobFailureCount": "Introspect Job Failure Count:",
600+
"domain-design-domain-status-observedGeneration": "Observed Generation:",
600601
"domain-design-domain-status-message": "Last Error Message:",
601602
"domain-design-domain-status-conditions": "Conditions:",
602603
"domain-design-domain-status-clusterstatus": "Cluster Status:",

webui/src/js/utils/k8s-domain-actions-base.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,10 @@ function (WktActionsBase, project, wktConsole, i18n, projectIo, dialogHelper) {
117117
} else if (completeCondition.status === 'False' && availableCondition.status === 'False') {
118118
result['domainOverallStatus'] = i18n.t('k8s-domain-status-checker-domain-status-available',
119119
{reason: latestCondition.reason});
120-
} else {
120+
} else if (completeCondition.status === 'True' && availableCondition.status === 'False') {
121+
result['domainOverallStatus'] = i18n.t('k8s-domain-status-checker-domain-status-available',
122+
{reason: latestCondition.reason});
123+
} else {
121124
// should never happened?
122125
result['domainOverallStatus'] = i18n.t('k8s-domain-status-checker-domain-status-unknown',
123126
{reason: latestCondition.reason});

webui/src/js/viewModels/domain-status-dialog.js

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,13 +52,26 @@ function(accUtils, ko, jsyaml, i18n, project) {
5252
this.domainServerStatus = '';
5353
this.introspectJobFailureCount = 0;
5454
this.domainHasError = false;
55+
this.isOperatorVersion4orHigher = false;
56+
57+
if (!project.wko.installedVersion.hasValue() ||
58+
window.api.utils.compareVersions(project.wko.installedVersion.value, '4.0.0') >= 0) {
59+
this.isOperatorVersion4orHigher = true;
60+
}
5561

5662
if ('status' in this.domainStatus && 'conditions' in this.domainStatus.status) {
5763
this.domainConditions = this.makeYamlOutput(this.domainStatus.status.conditions);
5864
this.domainClusterStatus = this.makeYamlOutput(this.domainStatus.status.clusters);
5965
this.domainServerStatus = this.makeYamlOutput(this.domainStatus.status.servers);
6066
this.domainName = this.domainStatus.spec.domainUID;
61-
this.introspectJobFailureCount = this.domainStatus.status.introspectJobFailureCount;
67+
if (this.isOperatorVersion4orHigher) {
68+
// 4.0 higher is not named introspectJobFailureCount but observeredGeneation in the status
69+
// text in the diaglog have been changed to Observed Generation to match, this is just a holder of the value
70+
this.introspectJobFailureCount = this.domainStatus.status.observedGeneration;
71+
} else {
72+
this.introspectJobFailureCount = this.domainStatus.status.introspectJobFailureCount;
73+
}
74+
6275
const conditions = this.domainStatus.status.conditions;
6376
conditions.sort((a, b) => {
6477
if ( a.lastTransitionTime < b.lastTransitionTime ){

webui/src/js/views/domain-status-dialog.html

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,18 @@
1818
</div>
1919

2020
<div class="oj-panel wkt-notop">
21-
<oj-label for="introspectJobFailureCount">
22-
<oj-bind-text value="{{labelMapper('domain-status-introspectJobFailureCount')}}"></oj-bind-text>
23-
</oj-label>
21+
<oj-bind-if test="[[isOperatorVersion4orHigher === false]]">
22+
<oj-label for="introspectJobFailureCount">
23+
<oj-bind-text value="{{labelMapper('domain-status-introspectJobFailureCount')}}"></oj-bind-text>
24+
</oj-label>
25+
</oj-bind-if>
26+
27+
<oj-bind-if test="[[isOperatorVersion4orHigher === true]]">
28+
<oj-label for="introspectJobFailureCount">
29+
<oj-bind-text value="{{labelMapper('domain-status-observedGeneration')}}"></oj-bind-text>
30+
</oj-label>
31+
</oj-bind-if>
32+
2433
<br>
2534
<oj-input-text id="introspectJobFailureCount" value="{{introspectJobFailureCount}}" readonly="true"></oj-input-text>
2635
</div>

0 commit comments

Comments
 (0)