fixing sonar issue (#122)

Author: robertpatrick

electron/app/js/k8sUtils.js

@@ -17,7 +17,7 @@ function getKubeConfig() {
     kubeConfig = process.env.KUBECONFIG.split(path.delimiter);
   } else {
     const userHomeDir = osUtils.isWindows() ? process.env.USERPROFILE : process.env.HOME;
-    kubeConfig = path.normalize(path.join(userHomeDir, '.kube', 'config'));
+    kubeConfig = [ path.normalize(path.join(userHomeDir, '.kube', 'config')) ];
   }
   return kubeConfig;
 }

webui/src/js/models/kubectl-definition.js

@@ -18,17 +18,7 @@ define(['utils/observable-properties'],
     return function (name) {
       return {
         k8sFlavor: props.createProperty('OKE'),
-        kubeConfig: props.createArrayProperty(() => {
-          const kubeConfig = window.api.k8s.getKubeConfig();
-          if (kubeConfig) {
-            if (Array.isArray(kubeConfig)) {
-              return kubeConfig;
-            } else {
-              return [ kubeConfig ];
-            }
-          }
-          return [];
-        }),
+        kubeConfig: props.createArrayProperty(window.api.k8s.getKubeConfig()),
         executableFilePath: props.createProperty(window.api.k8s.getKubectlFilePath()),
         kubeConfigContextToUse: props.createProperty(),
         helmExecutableFilePath: props.createProperty(window.api.k8s.getHelmFilePath()),

webui/src/test/window-stub.js

@@ -30,7 +30,7 @@ class WindowStub {
     const api = {
       k8s : {
         getKubeConfig: () => {
-          return 'fake-kube-config';
+          return ['fake-kube-config'];
         },
         getKubectlFilePath: () => {
           return '/fake/kubectl';