[GR-17457] Optimize Identifiers#isInitialCharacter

eregon · eregon · commit 5df847e06f65 · 2024-01-31T13:53:06.000Z
PullRequest: truffleruby/4143
diff --git a/src/main/java/org/truffleruby/parser/Identifiers.java b/src/main/java/org/truffleruby/parser/Identifiers.java
@@ -91,7 +91,7 @@ private static boolean isNameString(String id, int start) {
     // MRI: similar to is_identchar but does not allow numeric
     @TruffleBoundary
     private static boolean isInitialCharacter(int c) {
-        return Character.isAlphabetic(c) || c == '_' || c >= 128;
+        return c >= 128 || c == '_' || Character.isAlphabetic(c);
     }
 
     private static boolean isConstantFirstCodePoint(int first) {

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ private static boolean isNameString(String id, int start) {`
`91`	`91`	`// MRI: similar to is_identchar but does not allow numeric`
`92`	`92`	`@TruffleBoundary`
`93`	`93`	`private static boolean isInitialCharacter(int c) {`
`94`		`- return Character.isAlphabetic(c) \|\| c == '_' \|\| c >= 128;`
	`94`	`+ return c >= 128 \|\| c == '_' \|\| Character.isAlphabetic(c);`
`95`	`95`	`}`
`96`	`96`
`97`	`97`	`private static boolean isConstantFirstCodePoint(int first) {`