Remove hinting at MySQL 8-specific behavior (#133)

gianlucaborello · owainlewis · commit e33d324c98f1 · 2018-06-26T11:23:58.000+01:00
Signed-off-by: Gianluca Borello &lt;g.borello@gmail.com&gt;
diff --git a/pkg/controllers/cluster/manager/cluster_manager.go b/pkg/controllers/cluster/manager/cluster_manager.go
@@ -235,7 +235,6 @@ func (m *ClusterManager) ensurePrimaryControllerState(ctx context.Context, statu
 	}
 }
 
-// NOTE: This should never happen in 8.0 but probably worth keeping for now.
 func (m *ClusterManager) handleInstanceMissing(ctx context.Context, primaryAddr string) bool {
 	primaryURI := fmt.Sprintf("%s:%s@%s", m.Instance.GetUser(), m.Instance.GetPassword(), primaryAddr)
 	primarySh := m.mysqlshFactory(primaryURI)

Original file line number	Diff line number	Diff line change
`@@ -235,7 +235,6 @@ func (m *ClusterManager) ensurePrimaryControllerState(ctx context.Context, statu`
`235`	`235`	`}`
`236`	`236`	`}`
`237`	`237`
`238`		`-// NOTE: This should never happen in 8.0 but probably worth keeping for now.`
`239`	`238`	`func (m *ClusterManager) handleInstanceMissing(ctx context.Context, primaryAddr string) bool {`
`240`	`239`	`primaryURI := fmt.Sprintf("%s:%s@%s", m.Instance.GetUser(), m.Instance.GetPassword(), primaryAddr)`
`241`	`240`	`primarySh := m.mysqlshFactory(primaryURI)`