Skip to content

Commit ef9c70c

Browse files
committed
Merge remote-tracking branch 'origin/otethal/truffle_string' into fa/labs-numpy-hpy-port
2 parents 2dfee04 + d0011d1 commit ef9c70c

File tree

6 files changed

+10
-13
lines changed

6 files changed

+10
-13
lines changed

ci.jsonnet

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{ "overlay": "8389e99d9899cbf8f939927c130982eab7dfd24e" }
1+
{ "overlay": "1143cb42864b0555ad23080c5b5b2850c547bdd8" }

graalpython/com.oracle.graal.python.test/src/tests/unittest_tags/test_poplib.txt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,6 @@
4444
*graalpython.lib-python.3.test.test_poplib.TestPOP3_SSLClass.test_utf8
4545
*graalpython.lib-python.3.test.test_poplib.TestPOP3_SSLClass.test_utf8_raises_if_unsupported
4646
*graalpython.lib-python.3.test.test_poplib.TestPOP3_TLSClass.test_apop_REDOS
47-
*graalpython.lib-python.3.test.test_poplib.TestPOP3_TLSClass.test_apop_normal
48-
*graalpython.lib-python.3.test.test_poplib.TestPOP3_TLSClass.test_capa
49-
*graalpython.lib-python.3.test.test_poplib.TestPOP3_TLSClass.test_dele
5047
*graalpython.lib-python.3.test.test_poplib.TestPOP3_TLSClass.test_exceptions
5148
*graalpython.lib-python.3.test.test_poplib.TestPOP3_TLSClass.test_getwelcome
5249
*graalpython.lib-python.3.test.test_poplib.TestPOP3_TLSClass.test_list

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/str/StringBuiltins.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
*/
2626
package com.oracle.graal.python.builtins.objects.str;
2727

28-
import static com.oracle.graal.python.builtins.objects.str.StringUtils.LAZY_CODEPOINT_THRESHOLD;
2928
import static com.oracle.graal.python.nodes.BuiltinNames.J_ENCODE;
3029
import static com.oracle.graal.python.nodes.BuiltinNames.J_ENDSWITH;
3130
import static com.oracle.graal.python.nodes.BuiltinNames.J_FORMAT;
@@ -151,7 +150,6 @@
151150
import com.oracle.graal.python.nodes.util.CastToTruffleStringNode;
152151
import com.oracle.graal.python.runtime.ExecutionContext.IndirectCallContext;
153152
import com.oracle.graal.python.runtime.PythonContext;
154-
import com.oracle.graal.python.runtime.PythonOptions;
155153
import com.oracle.graal.python.runtime.exception.PException;
156154
import com.oracle.graal.python.runtime.formatting.InternalFormat;
157155
import com.oracle.graal.python.runtime.formatting.InternalFormat.Spec;
@@ -504,7 +502,7 @@ public static AddNode create() {
504502
@Specialization
505503
TruffleString doIt(TruffleString self, TruffleString other,
506504
@Shared("concat") @Cached TruffleString.ConcatNode concatNode) {
507-
return concatNode.execute(self, other, TS_ENCODING, getContext().getOption(PythonOptions.LazyStrings));
505+
return concatNode.execute(self, other, TS_ENCODING, false);
508506
}
509507

510508
@Specialization
@@ -2508,7 +2506,7 @@ public TruffleString doString(VirtualFrame frame, Object self, Object idx,
25082506
if (index < 0 || index >= len) {
25092507
throw raise(IndexError, ErrorMessages.STRING_INDEX_OUT_OF_RANGE);
25102508
}
2511-
return substringNode.execute(str, index, 1, TS_ENCODING, getContext().getOption(PythonOptions.LazyStrings) && len < LAZY_CODEPOINT_THRESHOLD);
2509+
return substringNode.execute(str, index, 1, TS_ENCODING, false);
25122510
}
25132511
}
25142512

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/lib/PyObjectStrAsObjectNode.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@
5858
import com.oracle.graal.python.nodes.call.special.LookupSpecialMethodSlotNode;
5959
import com.oracle.graal.python.nodes.classes.IsSubtypeNode;
6060
import com.oracle.graal.python.nodes.object.GetClassNode;
61-
import com.oracle.graal.python.runtime.PythonOptions;
6261
import com.oracle.truffle.api.dsl.Cached;
6362
import com.oracle.truffle.api.dsl.GenerateUncached;
6463
import com.oracle.truffle.api.dsl.ImportStatic;
@@ -93,7 +92,7 @@ static TruffleString str(boolean object) {
9392
@Specialization
9493
TruffleString str(long object,
9594
@Cached TruffleString.FromLongNode fromLongNode) {
96-
return fromLongNode.execute(object, TS_ENCODING, getContext().getOption(PythonOptions.LazyStrings));
95+
return fromLongNode.execute(object, TS_ENCODING, false);
9796
}
9897

9998
@Specialization(guards = "!isTruffleString(obj)")

mx.graalpython/mx_graalpython.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -419,6 +419,9 @@ def update_unittest_tags(args):
419419
('test_imaplib.txt', '*graalpython.lib-python.3.test.test_imaplib.NewIMAPTests.test_login_cram_md5_plain_text'),
420420
('test_poplib.txt', '*graalpython.lib-python.3.test.test_poplib.TestPOP3_TLSClass.test_noop'),
421421
('test_poplib.txt', '*graalpython.lib-python.3.test.test_poplib.TestPOP3_TLSClass.test_pass_'),
422+
('test_poplib.txt', '*graalpython.lib-python.3.test.test_poplib.TestPOP3_TLSClass.test_apop_normal'),
423+
('test_poplib.txt', '*graalpython.lib-python.3.test.test_poplib.TestPOP3_TLSClass.test_capa'),
424+
('test_poplib.txt', '*graalpython.lib-python.3.test.test_poplib.TestPOP3_TLSClass.test_dele'),
422425
('test_weakref.txt', '*graalpython.lib-python.3.test.test_weakref.MappingTestCase.test_weak_keyed_len_cycles'),
423426
# Disabled since code object comparison is not stable for us
424427
('test_marshal.txt', '*graalpython.lib-python.3.test.test_marshal.InstancingTestCase.testModule'),

mx.graalpython/suite.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,23 +44,23 @@
4444
},
4545
{
4646
"name": "tools",
47-
"version": "18c276f625350ea50c695971068f5b758756c5db",
47+
"version": "1f62020c682ca5675af0a622ac70c8e1d5781224",
4848
"subdir": True,
4949
"urls": [
5050
{"url": "https://github.com/oracle/graal", "kind": "git"},
5151
],
5252
},
5353
{
5454
"name": "sulong",
55-
"version": "18c276f625350ea50c695971068f5b758756c5db",
55+
"version": "1f62020c682ca5675af0a622ac70c8e1d5781224",
5656
"subdir": True,
5757
"urls": [
5858
{"url": "https://github.com/oracle/graal", "kind": "git"},
5959
]
6060
},
6161
{
6262
"name": "regex",
63-
"version": "18c276f625350ea50c695971068f5b758756c5db",
63+
"version": "1f62020c682ca5675af0a622ac70c8e1d5781224",
6464
"subdir": True,
6565
"urls": [
6666
{"url": "https://github.com/oracle/graal", "kind": "git"},

0 commit comments

Comments
 (0)