Skip to content

Commit 8bd62c1

Browse files
committed
[GR-11528] Improve performance of binary arithmetic in C
PullRequest: graalpython/187
2 parents f34cb38 + cbe9027 commit 8bd62c1

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+1732
-337
lines changed
Lines changed: 83 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,83 @@
1+
# Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.
2+
# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
3+
#
4+
# The Universal Permissive License (UPL), Version 1.0
5+
#
6+
# Subject to the condition set forth below, permission is hereby granted to any
7+
# person obtaining a copy of this software, associated documentation and/or
8+
# data (collectively the "Software"), free of charge and under any and all
9+
# copyright rights in the Software, and any and all patent rights owned or
10+
# freely licensable by each licensor hereunder covering either (i) the
11+
# unmodified Software as contributed to or provided by such licensor, or (ii)
12+
# the Larger Works (as defined below), to deal in both
13+
#
14+
# (a) the Software, and
15+
#
16+
# (b) any piece of software and/or hardware listed in the lrgrwrks.txt file if
17+
# one is included with the Software each a "Larger Work" to which the Software
18+
# is contributed by such licensors),
19+
#
20+
# without restriction, including without limitation the rights to copy, create
21+
# derivative works of, display, perform, and distribute the Software and make,
22+
# use, sell, offer for sale, import, export, have made, and have sold the
23+
# Software and the Larger Work(s), and to sublicense the foregoing rights on
24+
# either these or other terms.
25+
#
26+
# This license is subject to the following condition:
27+
#
28+
# The above copyright notice and either this complete permission notice or at a
29+
# minimum a reference to the UPL must be included in all copies or substantial
30+
# portions of the Software.
31+
#
32+
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
33+
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
34+
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
35+
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
36+
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
37+
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
38+
# SOFTWARE.
39+
40+
class Foo(object):
41+
def __init__(self, a):
42+
self.a = a
43+
44+
def get_number(self):
45+
return self.a
46+
47+
def set_number(self, number):
48+
self.a = number
49+
50+
51+
class Bar(Foo):
52+
def __init__(self, b):
53+
super(Bar, self).__init__(b)
54+
self.b = b
55+
56+
def get_number(self):
57+
return self.b
58+
59+
def set_number(self, number):
60+
self.b = number
61+
62+
def get_super(self):
63+
return super()
64+
65+
66+
def do_stuff(bar):
67+
foobar = bar.get_super()
68+
for i in range(50000):
69+
local_number = foobar.get_number() + 1
70+
foobar.set_number(local_number)
71+
72+
return foobar.get_number(), bar.get_number()
73+
74+
75+
def measure(num):
76+
for i in range(num):
77+
result = do_stuff(Bar(42))
78+
79+
print(result)
80+
81+
82+
def __benchmark__(num=5000):
83+
measure(num)
Lines changed: 127 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,127 @@
1+
# Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved.
2+
# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
3+
#
4+
# The Universal Permissive License (UPL), Version 1.0
5+
#
6+
# Subject to the condition set forth below, permission is hereby granted to any
7+
# person obtaining a copy of this software, associated documentation and/or
8+
# data (collectively the "Software"), free of charge and under any and all
9+
# copyright rights in the Software, and any and all patent rights owned or
10+
# freely licensable by each licensor hereunder covering either (i) the
11+
# unmodified Software as contributed to or provided by such licensor, or (ii)
12+
# the Larger Works (as defined below), to deal in both
13+
#
14+
# (a) the Software, and
15+
#
16+
# (b) any piece of software and/or hardware listed in the lrgrwrks.txt file if
17+
# one is included with the Software each a "Larger Work" to which the Software
18+
# is contributed by such licensors),
19+
#
20+
# without restriction, including without limitation the rights to copy, create
21+
# derivative works of, display, perform, and distribute the Software and make,
22+
# use, sell, offer for sale, import, export, have made, and have sold the
23+
# Software and the Larger Work(s), and to sublicense the foregoing rights on
24+
# either these or other terms.
25+
#
26+
# This license is subject to the following condition:
27+
#
28+
# The above copyright notice and either this complete permission notice or at a
29+
# minimum a reference to the UPL must be included in all copies or substantial
30+
# portions of the Software.
31+
#
32+
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
33+
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
34+
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
35+
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
36+
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
37+
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
38+
# SOFTWARE.
39+
40+
code = """
41+
#include <Python.h>
42+
#include "structmember.h"
43+
44+
static PyTypeObject FloatSubclass = {
45+
PyVarObject_HEAD_INIT(NULL, 0)
46+
"FloatSubclass", /* tp_name */
47+
sizeof(PyFloatObject), /* tp_basicsize */
48+
0, /* tp_itemsize */
49+
0, /* tp_dealloc */
50+
0, /* tp_print */
51+
0, /* tp_getattr */
52+
0, /* tp_setattr */
53+
0, /* tp_reserved */
54+
0, /* tp_repr */
55+
0, /* tp_as_number */
56+
0, /* tp_as_sequence */
57+
0, /* tp_as_mapping */
58+
0, /* tp_hash */
59+
0, /* tp_call */
60+
0, /* tp_str */
61+
0, /* tp_getattro */
62+
0, /* tp_setattro */
63+
0, /* tp_as_buffer */
64+
Py_TPFLAGS_DEFAULT |
65+
Py_TPFLAGS_BASETYPE, /* tp_flags */
66+
"", /* tp_doc */
67+
0, /* tp_traverse */
68+
0, /* tp_clear */
69+
0, /* tp_richcompare */
70+
0, /* tp_weaklistoffset */
71+
0, /* tp_iter */
72+
0, /* tp_iternext */
73+
0, /* tp_methods */
74+
0, /* tp_members */
75+
0, /* tp_getset */
76+
&PyFloat_Type, /* tp_base */
77+
0, /* tp_dict */
78+
0, /* tp_descr_get */
79+
0, /* tp_descr_set */
80+
0, /* tp_dictoffset */
81+
0, /* tp_init */
82+
0, /* tp_alloc */
83+
0, /* tp_new */
84+
};
85+
86+
static PyModuleDef module = {
87+
PyModuleDef_HEAD_INIT,
88+
"module",
89+
"",
90+
-1,
91+
NULL, NULL, NULL, NULL, NULL
92+
};
93+
94+
PyMODINIT_FUNC
95+
PyInit_c_arith_binop_module(void) {
96+
PyType_Ready(&FloatSubclass);
97+
PyObject* m = PyModule_Create(&module);
98+
Py_INCREF(&FloatSubclass);
99+
PyModule_AddObject(m, "FloatSubclass", (PyObject *)&FloatSubclass);
100+
return m;
101+
}
102+
"""
103+
104+
105+
ccompile("c_arith_binop_module", code)
106+
from c_arith_binop_module import FloatSubclass
107+
108+
109+
def docompute(num):
110+
for i in range(num):
111+
sum_ = FloatSubclass(0.0)
112+
j = FloatSubclass(0)
113+
while j < num:
114+
sum_ += 1.0 / ((i + j) * (i + j + 1) + i + 1)
115+
j += 1
116+
117+
return sum_
118+
119+
120+
def measure(num):
121+
for run in range(num):
122+
sum_ = docompute(1000)
123+
print("sum", sum_)
124+
125+
126+
def __benchmark__(num=5):
127+
measure(num)

0 commit comments

Comments
 (0)