fix a few warnings and errors on eclipse

Author: timfel

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/SysModuleBuiltins.java

@@ -152,7 +152,6 @@
 import com.oracle.graal.python.builtins.PythonOS;
 import com.oracle.graal.python.builtins.modules.SysModuleBuiltinsClinicProviders.GetFrameNodeClinicProviderGen;
 import com.oracle.graal.python.builtins.modules.SysModuleBuiltinsClinicProviders.SetDlopenFlagsClinicProviderGen;
-import com.oracle.graal.python.builtins.modules.SysModuleBuiltinsFactory.ExcInfoNodeFactory;
 import com.oracle.graal.python.builtins.modules.io.BufferedReaderBuiltins;
 import com.oracle.graal.python.builtins.modules.io.BufferedWriterBuiltins;
 import com.oracle.graal.python.builtins.modules.io.FileIOBuiltins;
@@ -856,12 +855,6 @@ static PTuple run(VirtualFrame frame,
                 return factory.createTuple(new Object[]{getClassNode.execute(inliningTarget, exceptionObject), exceptionObject, traceback});
             }
         }
-
-        @NeverDefault
-        public static ExcInfoNode create() {
-            return ExcInfoNodeFactory.create(null);
-        }
-
     }
 
     // ATTENTION: this is intentionally a PythonBuiltinNode and not PythonUnaryBuiltinNode,

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/cext/PythonCextErrBuiltins.java

@@ -73,6 +73,7 @@
 import com.oracle.graal.python.builtins.modules.PosixModuleBuiltins.ExitNode;
 import com.oracle.graal.python.builtins.modules.SysModuleBuiltins;
 import com.oracle.graal.python.builtins.modules.SysModuleBuiltins.ExcInfoNode;
+import com.oracle.graal.python.builtins.modules.SysModuleBuiltinsFactory.ExcInfoNodeFactory;
 import com.oracle.graal.python.builtins.modules.cext.PythonCextBuiltins.CApiBinaryBuiltinNode;
 import com.oracle.graal.python.builtins.modules.cext.PythonCextBuiltins.CApiBuiltin;
 import com.oracle.graal.python.builtins.modules.cext.PythonCextBuiltins.CApiNullaryBuiltinNode;
@@ -444,11 +445,15 @@ static Object write(Object msg, Object obj,
 
     @CApiBuiltin(ret = Void, args = {Int}, call = Direct)
     abstract static class PyErr_PrintEx extends CApiUnaryBuiltinNode {
+        static ExcInfoNode createExcInfoNode() {
+            return ExcInfoNodeFactory.create(null);
+        }
+
         @TruffleBoundary
         @Specialization
         static Object raise(int set_sys_last_vars,
                         @Cached IsInstanceNode isInstanceNode,
-                        @Cached ExcInfoNode excInfoNode,
+                        @Cached(neverDefault = true, value = "createExcInfoNode()") ExcInfoNode excInfoNode,
                         @Cached PyErr_Restore restoreNode,
                         @Cached PyFile_WriteObject writeFileNode,
                         @Cached ExitNode exitNode,

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/cext/capi/PythonNativeWrapper.java

@@ -119,11 +119,11 @@ public final boolean isNative() {
      * transition code will consider that and eagerly return the pointer object. If {@code true} is
      * returned, the wrapper must also implement {@link #getReplacement(InteropLibrary)} which
      * returns the pointer object. Furthermore, wrappers must use
-     * {@link #registerReplacement(Object, InteropLibrary)} to register the allocated native memory
-     * in order that the native pointer can be resolved to the managed wrapper in the
+     * {@link #registerReplacement(Object, boolean, InteropLibrary)} to register the allocated
+     * native memory in order that the native pointer can be resolved to the managed wrapper in the
      * <it>native-to-Python</it> transition.
      * </p>
-     * 
+     *
      * @return {@code true} if the wrapper should be materialized eagerly, {@code false} otherwise.
      */
     public final boolean isReplacingWrapper() {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/argument/CreateArgumentsNode.java

@@ -235,7 +235,7 @@ public abstract static class CreateAndCheckArgumentsNode extends PNodeWithContex
          *
          * @param inliningTarget The inlining target.
          * @param callableOrName This object can either be the function/method object or just a name
-         *            ({@link TruffleString)}. It is primarily used to create error messages. It is
+         *            ({@link TruffleString}). It is primarily used to create error messages. It is
          *            also used to check if the function
          * @param userArguments The positional arguments as provided by the caller (must not be
          *            {@code null} but may be empty).

mx.graalpython/eclipse-settings/org.eclipse.jdt.core.prefs

@@ -1 +1,2 @@
 org.eclipse.jdt.core.compiler.problem.unusedParameter=ignore
+org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=warning