Workaround Truffle bug in fallback guard in IntBuiltins#AddNode

Author: steve-s

graalpython/com.oracle.graal.python.cext/src/tupleobject.c

@@ -1361,7 +1361,7 @@ PyObject **
 PyTruffleTuple_GetItems(PyObject *op)
 {
 #ifdef GRAALVM_PYTHON_LLVM_MANAGED
-    return GraalPy_get_PyTupleObject_ob_item(op);
+    return GraalPy_get_PyTupleObject_ob_item((PyTupleObject*) op);
 #else /* GRAALVM_PYTHON_LLVM_MANAGED */
     PyObject *res;
     PyObject **ob_item;

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/foreign/ForeignObjectBuiltins.java

@@ -423,8 +423,7 @@ Object doBool(Object obj, @SuppressWarnings("unused") boolean doArray,
             try {
                 return lib.asBoolean(obj);
             } catch (UnsupportedMessageException e) {
-                CompilerDirectives.transferToInterpreterAndInvalidate();
-                throw new IllegalStateException("object does not unpack to boolean as it claims to");
+                throw CompilerDirectives.shouldNotReachHere(e);
             } finally {
                 gil.acquire();
             }
@@ -439,8 +438,7 @@ Object doLong(Object obj, @SuppressWarnings("unused") boolean doArray,
             try {
                 return lib.asLong(obj);
             } catch (UnsupportedMessageException e) {
-                CompilerDirectives.transferToInterpreterAndInvalidate();
-                throw new IllegalStateException("object does not unpack to long as it claims to");
+                throw CompilerDirectives.shouldNotReachHere(e);
             } finally {
                 gil.acquire();
             }
@@ -456,8 +454,7 @@ Object doBigInt(Object obj, @SuppressWarnings("unused") boolean doArray,
             try {
                 return factory.createInt(lib.asBigInteger(obj));
             } catch (UnsupportedMessageException e) {
-                CompilerDirectives.transferToInterpreterAndInvalidate();
-                throw new IllegalStateException("object does not unpack to BigInteger as it claims to");
+                throw CompilerDirectives.shouldNotReachHere(e);
             } finally {
                 gil.acquire();
             }
@@ -472,8 +469,7 @@ Object doDouble(Object obj, @SuppressWarnings("unused") boolean doArray,
             try {
                 return lib.asDouble(obj);
             } catch (UnsupportedMessageException e) {
-                CompilerDirectives.transferToInterpreterAndInvalidate();
-                throw new IllegalStateException("object does not unpack to double as it claims to");
+                throw CompilerDirectives.shouldNotReachHere(e);
             } finally {
                 gil.acquire();
             }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/ints/IntBuiltins.java

@@ -454,8 +454,14 @@ static BigInteger op(BigInteger left, BigInteger right) {
             return left.add(right);
         }
 
+        static boolean isNotImplemented(Object x) {
+            return !(x instanceof Long || x instanceof Integer || x instanceof Boolean || x instanceof PInt);
+        }
+
+        // There is a Truffle bug (GR-57305) that constructs a wrong fallback guard in the presence
+        // of implicit casts, so we cannot use @Fallback for now
         @SuppressWarnings("unused")
-        @Fallback
+        @Specialization(guards = {"isNotImplemented(left) || isNotImplemented(right)"})
         static PNotImplemented doGeneric(Object left, Object right) {
             return PNotImplemented.NOT_IMPLEMENTED;
         }