feat: conversion error test (#41)

Author: csviri

samples/quarkus/src/test/java/io/javaoperatorsdk/webhook/admission/sample/quarkus/conversion/ConversionEndpointTest.java

@@ -31,17 +31,43 @@ void asyncConversion() {
     testConversion(ASYNC_CONVERSION_PATH);
   }
 
+  @Test
+  void errorConversion() {
+    testErrorConversion(CONVERSION_PATH);
+  }
+
+  @Test
+  void asyncErrorConversion() {
+    testErrorConversion(ASYNC_CONVERSION_PATH);
+  }
+
+  private void testErrorConversion(String conversionPath) {
+    given().contentType(ContentType.JSON)
+        .body(errorRequest())
+        .when().post("/" + conversionPath)
+        .then()
+        .statusCode(500);
+  }
+
   public void testConversion(String path) {
     given().contentType(ContentType.JSON)
-        .body(jsonRequest())
+        .body(request())
         .when().post("/" + path)
         .then()
         .statusCode(200)
         .body(is(expectedResult));
   }
 
-  private String jsonRequest() {
-    try (InputStream is = this.getClass().getResourceAsStream("/conversion-request.json")) {
+  private String errorRequest() {
+    return request("/conversion-error-request.json");
+  }
+
+  private String request() {
+    return request("/conversion-request.json");
+  }
+
+  private String request(String path) {
+    try (InputStream is = this.getClass().getResourceAsStream(path)) {
       return new String(is.readAllBytes(), StandardCharsets.UTF_8);
     } catch (IOException e) {
       throw new IllegalStateException(e);

samples/quarkus/src/test/resources/conversion-error-request.json

@@ -0,0 +1,30 @@
+{
+  "apiVersion": "apiextensions.k8s.io/v1",
+  "kind": "ConversionReview",
+  "request": {
+
+  "uid": "705ab4f5-6393-11e8-b7cc-42010a800002",
+
+  "desiredAPIVersion": "sample.javaoperatorsdk/v2",
+
+  "objects": [
+    {
+      "kind": "MultiVersionCustomResource",
+      "apiVersion": "sample.javaoperatorsdk/v2",
+      "metadata": {
+        "creationTimestamp": "2021-09-04T14:03:02Z",
+        "name": "resource1",
+        "namespace": "default",
+        "resourceVersion": "143",
+        "uid": "3415a7fc-162b-4300-b5da-fd6083580d66"
+      },
+      "spec": {
+        "value": "non integer"
+      },
+      "status":{
+        "ready": true
+      }
+    }
+  ]
+}
+}

samples/spring-boot/src/test/java/io/javaoperatorsdk/webhook/sample/springboot/conversion/ConversionEndpointTest.java

@@ -3,6 +3,7 @@
 import java.io.IOException;
 import java.nio.file.Files;
 
+import org.jetbrains.annotations.NotNull;
 import org.junit.jupiter.api.Test;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.beans.factory.annotation.Value;
@@ -32,6 +33,8 @@ class ConversionEndpointTest {
   @Value("classpath:conversion-request.json")
   private Resource request;
 
+  @Value("classpath:conversion-error-request.json")
+  private Resource errorRequest;
 
   @Test
   void convert() {
@@ -43,6 +46,23 @@ void asyncConvert() {
     testConversion(ASYNC_CONVERSION_PATH);
   }
 
+  @Test
+  void errorConversion() {
+    testErrorConversion(CONVERSION_PATH);
+  }
+
+  @Test
+  void asyncErrorConversion() {
+    testErrorConversion(ASYNC_CONVERSION_PATH);
+  }
+
+  private void testErrorConversion(String conversionPath) {
+    webClient.post().uri("/" + conversionPath).contentType(MediaType.APPLICATION_JSON)
+        .body(errorRequest())
+        .exchange()
+        .expectStatus().is5xxServerError();
+  }
+
   public void testConversion(String path) {
     webClient.post().uri("/" + path).contentType(MediaType.APPLICATION_JSON)
         .body(request())
@@ -57,11 +77,19 @@ public void testConversion(String path) {
   }
 
   private BodyInserter<String, ReactiveHttpOutputMessage> request() {
+    return requestFromResource(request);
+  }
+
+  private BodyInserter<String, ReactiveHttpOutputMessage> errorRequest() {
+    return requestFromResource(errorRequest);
+  }
+
+  @NotNull
+  private BodyInserter<String, ReactiveHttpOutputMessage> requestFromResource(Resource request) {
     try {
       return BodyInserters.fromValue(new String(Files.readAllBytes(request.getFile().toPath())));
     } catch (IOException e) {
       throw new IllegalStateException(e);
     }
   }
-
 }

samples/spring-boot/src/test/resources/conversion-error-request.json

@@ -0,0 +1,30 @@
+{
+  "apiVersion": "apiextensions.k8s.io/v1",
+  "kind": "ConversionReview",
+  "request": {
+
+  "uid": "705ab4f5-6393-11e8-b7cc-42010a800002",
+
+  "desiredAPIVersion": "sample.javaoperatorsdk/v2",
+
+  "objects": [
+    {
+      "kind": "MultiVersionCustomResource",
+      "apiVersion": "sample.javaoperatorsdk/v2",
+      "metadata": {
+        "creationTimestamp": "2021-09-04T14:03:02Z",
+        "name": "resource1",
+        "namespace": "default",
+        "resourceVersion": "143",
+        "uid": "3415a7fc-162b-4300-b5da-fd6083580d66"
+      },
+      "spec": {
+        "value": "non integer"
+      },
+      "status":{
+        "ready": true
+      }
+    }
+  ]
+}
+}