From 331ab664435a892544273f29d964495c6efa620f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Attila=20M=C3=A9sz=C3=A1ros?= Date: Mon, 18 Sep 2023 09:31:31 +0200 Subject: [PATCH 1/3] fix: leader election parallel issue MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Attila Mészáros --- .../java/io/javaoperatorsdk/operator/LeaderElectionManager.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/LeaderElectionManager.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/LeaderElectionManager.java index 1509d87f2a..95be66b15b 100644 --- a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/LeaderElectionManager.java +++ b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/LeaderElectionManager.java @@ -67,7 +67,7 @@ private void init(LeaderElectionConfiguration config) { config.getRenewDeadline(), config.getRetryPeriod(), leaderCallbacks(), - true, + false, config.getLeaseName())) .build(); } From ab1e2834a9bacf1119f515f8d66455726c9aa510 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Attila=20M=C3=A9sz=C3=A1ros?= Date: Mon, 18 Sep 2023 13:09:21 +0200 Subject: [PATCH 2/3] commnet MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Attila Mészáros --- .../java/io/javaoperatorsdk/operator/LeaderElectionManager.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/LeaderElectionManager.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/LeaderElectionManager.java index 95be66b15b..f5a0263d9d 100644 --- a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/LeaderElectionManager.java +++ b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/LeaderElectionManager.java @@ -67,7 +67,7 @@ private void init(LeaderElectionConfiguration config) { config.getRenewDeadline(), config.getRetryPeriod(), leaderCallbacks(), - false, + false, // this is required to receive stop event in all cases config.getLeaseName())) .build(); } From 5670139390ade056307dc83fe88627092bd27fa0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Attila=20M=C3=A9sz=C3=A1ros?= Date: Tue, 19 Sep 2023 10:45:56 +0200 Subject: [PATCH 3/3] comment MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Attila Mészáros --- .../io/javaoperatorsdk/operator/LeaderElectionManager.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/LeaderElectionManager.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/LeaderElectionManager.java index f5a0263d9d..e36d35530a 100644 --- a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/LeaderElectionManager.java +++ b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/LeaderElectionManager.java @@ -67,7 +67,9 @@ private void init(LeaderElectionConfiguration config) { config.getRenewDeadline(), config.getRetryPeriod(), leaderCallbacks(), - false, // this is required to receive stop event in all cases + // this is required to be false to receive stop event in all cases, thus stopLeading + // is called always when leadership is lost/cancelled + false, config.getLeaseName())) .build(); }