diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/LeaderElectionManager.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/LeaderElectionManager.java index 931a7ddf27..9d13d542c8 100644 --- a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/LeaderElectionManager.java +++ b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/LeaderElectionManager.java @@ -64,9 +64,7 @@ private LeaderCallbacks leaderCallbacks() { return new LeaderCallbacks( this::startLeading, this::stopLeading, - leader -> { - log.info("New leader with identity: {}", leader); - }); + leader -> log.info("New leader with identity: {}", leader)); } private void startLeading() { @@ -82,7 +80,7 @@ private void stopLeading() { } private String identity(LeaderElectionConfiguration config) { - var id = config.getIdentity().orElse(System.getenv("HOSTNAME")); + var id = config.getIdentity().orElseGet(() -> System.getenv("HOSTNAME")); if (id == null || id.isBlank()) { id = UUID.randomUUID().toString(); } diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/AbstractDependentResource.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/AbstractDependentResource.java index 5dbdba9358..1813e7229d 100644 --- a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/AbstractDependentResource.java +++ b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/AbstractDependentResource.java @@ -44,7 +44,7 @@ public ReconcileResult reconcile(P primary, Context

context) { if (updatable) { final var match = updater.match(actual, primary, context); if (!match.matched()) { - final var desired = match.computedDesired().orElse(desired(primary, context)); + final var desired = match.computedDesired().orElseGet(() -> desired(primary, context)); throwIfNull(desired, primary, "Desired"); logForOperation("Updating", primary, desired); var updatedResource = handleUpdate(actual, desired, primary, context); diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/ReconciliationDispatcher.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/ReconciliationDispatcher.java index 651fc70276..3db1b3c92a 100644 --- a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/ReconciliationDispatcher.java +++ b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/ReconciliationDispatcher.java @@ -165,7 +165,7 @@ private PostExecutionControl

handleErrorStatusHandler(P resource, P originalR Exception e) throws Exception { if (isErrorStatusHandlerPresent()) { try { - RetryInfo retryInfo = context.getRetryInfo().orElse(new RetryInfo() { + RetryInfo retryInfo = context.getRetryInfo().orElseGet(() -> new RetryInfo() { @Override public int getAttemptCount() { return 0; diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerManager.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerManager.java index 7ca398c615..09e262d3cf 100644 --- a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerManager.java +++ b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerManager.java @@ -127,11 +127,11 @@ public Stream list(String namespace, Predicate predicate) { if (isWatchingAllNamespaces()) { return getSource(ALL_NAMESPACES_MAP_KEY) .map(source -> source.list(namespace, predicate)) - .orElse(Stream.empty()); + .orElseGet(Stream::empty); } else { return getSource(namespace) .map(source -> source.list(predicate)) - .orElse(Stream.empty()); + .orElseGet(Stream::empty); } } diff --git a/sample-operators/mysql-schema/src/main/java/io/javaoperatorsdk/operator/sample/MySQLSchemaReconciler.java b/sample-operators/mysql-schema/src/main/java/io/javaoperatorsdk/operator/sample/MySQLSchemaReconciler.java index 05187aea2b..f433063d17 100644 --- a/sample-operators/mysql-schema/src/main/java/io/javaoperatorsdk/operator/sample/MySQLSchemaReconciler.java +++ b/sample-operators/mysql-schema/src/main/java/io/javaoperatorsdk/operator/sample/MySQLSchemaReconciler.java @@ -44,7 +44,7 @@ public UpdateControl reconcile(MySQLSchema schema, Context reconcile(Tomcat tomcat, Context context) { tomcat.getMetadata().getNamespace(), tomcat.getStatus().getReadyReplicas()); return UpdateControl.patchStatus(updatedTomcat); - }).orElse(UpdateControl.noUpdate()); + }).orElseGet(UpdateControl::noUpdate); } private Tomcat updateTomcatStatus(Tomcat tomcat, Deployment deployment) {