From d578c78441156772bddcc785df4047e28352a47a Mon Sep 17 00:00:00 2001 From: csviri Date: Mon, 19 Sep 2022 08:31:34 +0200 Subject: [PATCH 1/3] docs: fix reconciliation max interval and related issues --- docs/documentation/features.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/documentation/features.md b/docs/documentation/features.md index 72b73e9a21..5e3a25f974 100644 --- a/docs/documentation/features.md +++ b/docs/documentation/features.md @@ -262,8 +262,7 @@ automatically triggered even in the absence of other events. See how to override standard annotation: ```java -@ControllerConfiguration(finalizerName = NO_FINALIZER, - reconciliationMaxInterval = @ReconciliationMaxInterval( +@ControllerConfiguration(maxReconciliationInterval = @ReconciliationMaxInterval( interval = 50, timeUnit = TimeUnit.MILLISECONDS)) ``` @@ -272,7 +271,7 @@ The event is not propagated at a fixed rate, rather it's scheduled after each re next reconciliation will occur at most within the specified interval after the last reconciliation. This feature can be turned off by setting `reconciliationMaxInterval` -to [`Constants.NO_RECONCILIATION_MAX_INTERVAL`](https://github.com/java-operator-sdk/java-operator-sdk/blob/442e7d8718e992a36880e42bd0a5c01affaec9df/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/Constants.java#L8-L8) +to [`Constants.NO_MAX_RECONCILIATION_INTERVAL`](https://github.com/java-operator-sdk/java-operator-sdk/blob/main/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/Constants.java#L20-L20) or any non-positive number. The automatic retries are not affected by this feature so a reconciliation will be re-triggered From ac8d98e4df480bb7b2a42eb4c7fa9d0fc3302a93 Mon Sep 17 00:00:00 2001 From: csviri Date: Mon, 19 Sep 2022 08:33:14 +0200 Subject: [PATCH 2/3] fix --- docs/documentation/features.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/documentation/features.md b/docs/documentation/features.md index 5e3a25f974..42a1d0e797 100644 --- a/docs/documentation/features.md +++ b/docs/documentation/features.md @@ -262,7 +262,7 @@ automatically triggered even in the absence of other events. See how to override standard annotation: ```java -@ControllerConfiguration(maxReconciliationInterval = @ReconciliationMaxInterval( +@ControllerConfiguration(maxReconciliationInterval = @MaxReconciliationInterval( interval = 50, timeUnit = TimeUnit.MILLISECONDS)) ``` From 03752d500ceccde14535184a017762f0319a83ca Mon Sep 17 00:00:00 2001 From: csviri Date: Mon, 19 Sep 2022 08:33:42 +0200 Subject: [PATCH 3/3] fix --- docs/documentation/features.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/documentation/features.md b/docs/documentation/features.md index 42a1d0e797..639a15b90c 100644 --- a/docs/documentation/features.md +++ b/docs/documentation/features.md @@ -270,7 +270,7 @@ standard annotation: The event is not propagated at a fixed rate, rather it's scheduled after each reconciliation. So the next reconciliation will occur at most within the specified interval after the last reconciliation. -This feature can be turned off by setting `reconciliationMaxInterval` +This feature can be turned off by setting `maxReconciliationInterval` to [`Constants.NO_MAX_RECONCILIATION_INTERVAL`](https://github.com/java-operator-sdk/java-operator-sdk/blob/main/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/Constants.java#L20-L20) or any non-positive number.