From 220c79b6a5942929dc0af9a162e90c648e0f49d0 Mon Sep 17 00:00:00 2001 From: csviri Date: Tue, 24 May 2022 10:22:15 +0200 Subject: [PATCH 1/3] docs: javadoc on configuration service --- .../operator/api/config/ConfigurationServiceProvider.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceProvider.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceProvider.java index 1e6dd660cf..63b1cf1793 100644 --- a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceProvider.java +++ b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceProvider.java @@ -2,6 +2,9 @@ import java.util.function.Consumer; +/** + * For internal usage only. To access operator configuration through the code. + */ public class ConfigurationServiceProvider { static final ConfigurationService DEFAULT = new BaseConfigurationService(Utils.loadFromProperties()); From f64a632d8f0a275031664293ffef863c25e20b1e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Attila=20M=C3=A9sz=C3=A1ros?= Date: Tue, 24 May 2022 14:40:03 +0200 Subject: [PATCH 2/3] Update operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceProvider.java Co-authored-by: Chris Laprun --- .../operator/api/config/ConfigurationServiceProvider.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceProvider.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceProvider.java index 63b1cf1793..55c6f9a166 100644 --- a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceProvider.java +++ b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceProvider.java @@ -3,7 +3,7 @@ import java.util.function.Consumer; /** - * For internal usage only. To access operator configuration through the code. + * For internal usage only, to avoid passing the operator configuration around. Preferred way to get to the ConfigurationService is via the reconciliation context. */ public class ConfigurationServiceProvider { static final ConfigurationService DEFAULT = From 26592a31097e8298be2e9c0b6ea267da5709577f Mon Sep 17 00:00:00 2001 From: csviri Date: Tue, 24 May 2022 15:00:08 +0200 Subject: [PATCH 3/3] format fix --- .../operator/api/config/ConfigurationServiceProvider.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceProvider.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceProvider.java index 55c6f9a166..50419f6a5d 100644 --- a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceProvider.java +++ b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceProvider.java @@ -3,7 +3,8 @@ import java.util.function.Consumer; /** - * For internal usage only, to avoid passing the operator configuration around. Preferred way to get to the ConfigurationService is via the reconciliation context. + * For internal usage only, to avoid passing the operator configuration around. Preferred way to get + * to the ConfigurationService is via the reconciliation context. */ public class ConfigurationServiceProvider { static final ConfigurationService DEFAULT =