fix: DependentResourceNode must use spec name when available

Author: metacosm

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/workflow/DefaultManagedWorkflow.java

@@ -74,7 +74,8 @@ public Workflow<P> resolve(KubernetesClient client,
       ControllerConfiguration<P> configuration) {
     final var alreadyResolved = new HashMap<String, DependentResourceNode>(specs.size());
     for (DependentResourceSpec spec : specs) {
-      final var node = new DependentResourceNode(resolve(spec, client, configuration));
+      final var node =
+          new DependentResourceNode(spec.getName(), resolve(spec, client, configuration));
       alreadyResolved.put(node.getName(), node);
       spec.getDependsOn()
           .forEach(depend -> node.addDependsOnRelation(alreadyResolved.get((String) depend)));

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/workflow/DependentResourceNode.java

@@ -26,7 +26,6 @@ void addParent(DependentResourceNode parent) {
     parents.add(parent);
   }
 
-
   void addDependsOnRelation(DependentResourceNode node) {
     node.addParent(this);
     dependsOn.add(node);
@@ -92,16 +91,13 @@ public int hashCode() {
   }
 
 
-  public DependentResourceNode(DependentResource<R, P> dependentResource) {
-    this(dependentResource, null, null);
+  DependentResourceNode(DependentResource<R, P> dependentResource) {
+    this(getNameFor(dependentResource), dependentResource);
   }
 
-  public DependentResourceNode(DependentResource<R, P> dependentResource,
-      Condition<R, P> reconcilePrecondition, Condition<R, P> deletePostcondition) {
-    this.name = getNameFor(dependentResource);
+  DependentResourceNode(String name, DependentResource<R, P> dependentResource) {
+    this.name = name;
     setDependentResource(dependentResource);
-    setReconcilePrecondition(reconcilePrecondition);
-    setDeletePostcondition(deletePostcondition);
   }
 
   @SuppressWarnings("rawtypes")

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/workflow/WorkflowBuilder.java

@@ -61,8 +61,7 @@ public WorkflowBuilder<P> withDeletePostcondition(Condition deletePostcondition)
     return this;
   }
 
-  DependentResourceNode getNodeByDependentResource(
-      DependentResource<?, ?> dependentResource) {
+  DependentResourceNode getNodeByDependentResource(DependentResource<?, ?> dependentResource) {
     // first check by name
     final var node =
         dependentResourceNodes.get(DependentResourceNode.getNameFor(dependentResource));