Skip to content

Commit facf203

Browse files
committed
default rate limit
1 parent e6971a8 commit facf203

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

docs/documentation/features.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -324,6 +324,9 @@ intersections:
324324
will still happen, but won't reset the retry, will be still marked as the last attempt in the retry info. The point
325325
(1) still holds, but in case of an error, no retry will happen.
326326

327+
## Rate Limiting Reconciliation
328+
329+
327330
## Handling Related Events with Event Sources
328331

329332
See also this [blog post](https://csviri.medium.com/java-operator-sdk-introduction-to-event-sources-a1aab5af4b7b).

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/ControllerConfiguration.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
import java.lang.annotation.Target;
77

88
import io.javaoperatorsdk.operator.api.reconciler.dependent.Dependent;
9-
import io.javaoperatorsdk.operator.processing.event.rate.PeriodRateLimiter;
109
import io.javaoperatorsdk.operator.processing.event.source.controller.ResourceEventFilter;
1110

1211
@Retention(RetentionPolicy.RUNTIME)
@@ -71,8 +70,7 @@ ReconciliationMaxInterval reconciliationMaxInterval() default @ReconciliationMax
7170
interval = 10);
7271

7372

74-
RateLimiter rateLimiter() default @RateLimiter(limitForPeriod = PeriodRateLimiter.NO_LIMIT_PERIOD,
75-
refreshPeriod = 1);
73+
RateLimiter rateLimiter() default @RateLimiter;
7674

7775
/**
7876
* Optional list of {@link Dependent} configurations which associate a resource type to a

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/RateLimiter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
@Target({ElementType.TYPE})
1313
public @interface RateLimiter {
1414

15-
int limitForPeriod() default PeriodRateLimiter.NO_LIMIT_PERIOD;
15+
int limitForPeriod() default PeriodRateLimiter.DEFAULT_LIMIT_FOR_PERIOD;
1616

1717
int refreshPeriod() default PeriodRateLimiter.DEFAULT_REFRESH_PERIOD_SECONDS;
1818

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/rate/PeriodRateLimiter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@
1414
public class PeriodRateLimiter implements RateLimiter {
1515

1616
public static final int DEFAULT_REFRESH_PERIOD_SECONDS = 2;
17+
public static final int DEFAULT_LIMIT_FOR_PERIOD = 3;
1718
public static final Duration DEFAULT_REFRESH_PERIOD =
1819
Duration.ofSeconds(DEFAULT_REFRESH_PERIOD_SECONDS);
1920

20-
public static final int DEFAULT_LIMIT_FOR_PERIOD = 3;
2121
/** To turn off rate limiting set limit fod period to a non-positive number */
2222
public static final int NO_LIMIT_PERIOD = -1;
2323

0 commit comments

Comments
 (0)