fix: properly set deprecated filters when overriding configuration

metacosm · metacosm · commit d0d0da06854a · 2022-12-02T12:50:12.000+01:00
diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ControllerConfigurationOverrider.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ControllerConfigurationOverrider.java
@@ -192,10 +192,13 @@ public ControllerConfiguration<R> build() {
           }
         }).collect(Collectors.toList());
 
-    return new ResolvedControllerConfiguration<>(original.getResourceClass(), original.getName(),
+    final var overridden = new ResolvedControllerConfiguration<>(
+        original.getResourceClass(), original.getName(),
         generationAware, original.getAssociatedReconcilerClassName(), retry, rateLimiter,
         reconciliationMaxInterval, onAddFilter, onUpdateFilter, genericFilter, newDependentSpecs,
         namespaces, finalizer, labelSelector);
+    overridden.setEventFilter(customResourcePredicate);
+    return overridden;
   }
 
   public static <R extends HasMetadata> ControllerConfigurationOverrider<R> override(

Original file line number	Diff line number	Diff line change
`@@ -192,10 +192,13 @@ public ControllerConfiguration<R> build() {`
`192`	`192`	`}`
`193`	`193`	`}).collect(Collectors.toList());`
`194`	`194`
`195`		`- return new ResolvedControllerConfiguration<>(original.getResourceClass(), original.getName(),`
	`195`	`+ final var overridden = new ResolvedControllerConfiguration<>(`
	`196`	`+ original.getResourceClass(), original.getName(),`
`196`	`197`	`generationAware, original.getAssociatedReconcilerClassName(), retry, rateLimiter,`
`197`	`198`	`reconciliationMaxInterval, onAddFilter, onUpdateFilter, genericFilter, newDependentSpecs,`
`198`	`199`	`namespaces, finalizer, labelSelector);`
	`200`	`+ overridden.setEventFilter(customResourcePredicate);`
	`201`	`+ return overridden;`
`199`	`202`	`}`
`200`	`203`
`201`	`204`	`public static <R extends HasMetadata> ControllerConfigurationOverrider<R> override(`