Skip to content

Commit d0c2091

Browse files
committed
test + docs
Signed-off-by: Attila Mészáros <csviri@gmail.com>
1 parent 7e7809d commit d0c2091

File tree

1 file changed

+17
-7
lines changed

1 file changed

+17
-7
lines changed

operator-framework/src/test/java/io/javaoperatorsdk/operator/config/BaseConfigurationServiceTest.java

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@
99
import java.util.Optional;
1010
import java.util.concurrent.TimeUnit;
1111

12+
import io.javaoperatorsdk.operator.ReconcilerUtils;
13+
import io.javaoperatorsdk.operator.api.reconciler.*;
1214
import org.junit.jupiter.api.Test;
1315

1416
import io.fabric8.kubernetes.api.model.ConfigMap;
@@ -18,12 +20,6 @@
1820
import io.javaoperatorsdk.operator.api.config.dependent.ConfigurationConverter;
1921
import io.javaoperatorsdk.operator.api.config.dependent.Configured;
2022
import io.javaoperatorsdk.operator.api.config.dependent.DependentResourceSpec;
21-
import io.javaoperatorsdk.operator.api.reconciler.Context;
22-
import io.javaoperatorsdk.operator.api.reconciler.ControllerConfiguration;
23-
import io.javaoperatorsdk.operator.api.reconciler.MaxReconciliationInterval;
24-
import io.javaoperatorsdk.operator.api.reconciler.Reconciler;
25-
import io.javaoperatorsdk.operator.api.reconciler.UpdateControl;
26-
import io.javaoperatorsdk.operator.api.reconciler.Workflow;
2723
import io.javaoperatorsdk.operator.api.reconciler.dependent.Dependent;
2824
import io.javaoperatorsdk.operator.api.reconciler.dependent.DependentResource;
2925
import io.javaoperatorsdk.operator.api.reconciler.dependent.ReconcileResult;
@@ -39,6 +35,8 @@
3935
import io.javaoperatorsdk.operator.processing.retry.RetryExecution;
4036
import io.javaoperatorsdk.operator.sample.readonly.ReadOnlyDependent;
4137

38+
import static io.javaoperatorsdk.operator.api.reconciler.MaxReconciliationInterval.DEFAULT_INTERVAL;
39+
import static org.assertj.core.api.Assertions.assertThat;
4240
import static org.junit.jupiter.api.Assertions.*;
4341

4442
class BaseConfigurationServiceTest {
@@ -105,8 +103,20 @@ void getDependentResources() {
105103
void missingAnnotationCreatesDefaultConfig() {
106104
final var reconciler = new MissingAnnotationReconciler();
107105
var config = configFor(reconciler);
108-
// todo asserts
109106

107+
assertThat(config.getName()).isEqualTo(ReconcilerUtils.getNameFor(reconciler));
108+
assertThat(config.getLabelSelector()).isEmpty();
109+
assertThat(config.getRetry()).isInstanceOf(GenericRetry.class);
110+
assertThat(config.getRateLimiter()).isInstanceOf(LinearRateLimiter.class);
111+
assertThat(config.maxReconciliationInterval()).hasValue(Duration.ofHours(DEFAULT_INTERVAL));
112+
assertThat(config.fieldManager()).isEqualTo(config.getName());
113+
assertThat(config.getInformerListLimit()).isEmpty();
114+
assertThat(config.onAddFilter()).isEmpty();
115+
assertThat(config.onUpdateFilter()).isEmpty();
116+
assertThat(config.genericFilter()).isEmpty();
117+
assertThat(config.getNamespaces()).isEqualTo(Constants.DEFAULT_NAMESPACES_SET);
118+
assertThat(config.getFinalizerName()).isEqualTo(ReconcilerUtils.getDefaultFinalizerName(config.getResourceClass()));
119+
assertThat(config.getItemStore()).isEmpty();
110120
}
111121

112122
@SuppressWarnings("rawtypes")

0 commit comments

Comments
 (0)