Skip to content

Commit ce3e39a

Browse files
committed
refactor: use isSameResource method
1 parent add9937 commit ce3e39a

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/AnnotationControllerConfiguration.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,8 @@ private Object createKubernetesResourceConfig(Class<? extends DependentResource>
311311
.orElse(null);
312312

313313
resourceDiscriminator =
314-
instantiateIfNotDefault(kubeDependent.resourceDiscriminator(), ResourceDiscriminator.class, context);
314+
instantiateIfNotDefault(kubeDependent.resourceDiscriminator(),
315+
ResourceDiscriminator.class, context);
315316
}
316317

317318
config =
@@ -321,7 +322,7 @@ private Object createKubernetesResourceConfig(Class<? extends DependentResource>
321322

322323
return config;
323324
}
324-
325+
325326
public static <T> T valueOrDefault(
326327
ControllerConfiguration controllerConfiguration,
327328
Function<ControllerConfiguration, T> mapper,

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/ResourceIDMatcherDiscriminator.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,7 @@ public ResourceIDMatcherDiscriminator(Function<P, ResourceID> mapper) {
1919
public Optional<R> distinguish(Class<R> resource, P primary, Context<P> context) {
2020
var resourceID = mapper.apply(primary);
2121
return context.getSecondaryResources(resource).stream()
22-
.filter(r -> r.getMetadata().getName()
23-
.equals(resourceID.getName()) &&
24-
resourceID.getNamespace().map(ns -> ns.equals(r.getMetadata().getNamespace()))
25-
.orElse(true))
22+
.filter(resourceID::isSameResource)
2623
.findFirst();
2724
}
2825
}

0 commit comments

Comments
 (0)