fixes from CR

Author: csviri

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationService.java

@@ -1,5 +1,6 @@
 package io.javaoperatorsdk.operator.api.config;
 
+import java.time.Duration;
 import java.util.Optional;
 import java.util.Set;
 import java.util.concurrent.ExecutorService;
@@ -170,8 +171,8 @@ default boolean stopOnInformerErrorDuringStartup() {
    * "stopOnInformerErrorDuringStartup" is true the operator will stop on timeout. Default is 2
    * minutes.
    */
-  default int cacheSyncTimeout() {
-    return 2 * 60 * 1000;
+  default Duration cacheSyncTimeout() {
+    return Duration.ofMinutes(2);
   }
 
   /**

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceOverrider.java

@@ -1,5 +1,6 @@
 package io.javaoperatorsdk.operator.api.config;
 
+import java.time.Duration;
 import java.util.Optional;
 import java.util.Set;
 import java.util.concurrent.ExecutorService;
@@ -28,7 +29,7 @@ public class ConfigurationServiceOverrider {
   private LeaderElectionConfiguration leaderElectionConfiguration;
   private InformerStoppedHandler informerStoppedHandler;
   private Boolean stopOnInformerErrorDuringStartup;
-  private Integer cacheSyncTimeout;
+  private Duration cacheSyncTimeout;
 
   ConfigurationServiceOverrider(ConfigurationService original) {
     this.original = original;
@@ -107,7 +108,7 @@ public ConfigurationServiceOverrider withStopOnInformerErrorDuringStartup(
     return this;
   }
 
-  public ConfigurationServiceOverrider withCacheSyncTimeout(int cacheSyncTimeout) {
+  public ConfigurationServiceOverrider withCacheSyncTimeout(Duration cacheSyncTimeout) {
     this.cacheSyncTimeout = cacheSyncTimeout;
     return this;
   }
@@ -192,7 +193,7 @@ public boolean stopOnInformerErrorDuringStartup() {
       }
 
       @Override
-      public int cacheSyncTimeout() {
+      public Duration cacheSyncTimeout() {
         return cacheSyncTimeout != null ? cacheSyncTimeout : super.cacheSyncTimeout();
       }
     };

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerWrapper.java

@@ -69,7 +69,8 @@ public void start() throws OperatorException {
         // note that in case we don't put here timeout and stopOnInformerErrorDuringStartup is
         // false, and there is a rbac issue the get never returns; therefore operator never really
         // starts
-        start.toCompletableFuture().get(configService.cacheSyncTimeout(), TimeUnit.MILLISECONDS);
+        start.toCompletableFuture().get(configService.cacheSyncTimeout().toMillis(),
+            TimeUnit.MILLISECONDS);
       } catch (TimeoutException | ExecutionException e) {
         log.warn("Informer startup error. Informer: {}", informer, e);
         if (configService.stopOnInformerErrorDuringStartup()) {

operator-framework/src/test/java/io/javaoperatorsdk/operator/InformerRelatedBehaviorITS.java

@@ -189,7 +189,7 @@ Operator startOperator(boolean stopOnInformerErrorDuringStartup) {
     Operator operator = new Operator(clientUsingServiceAccount(),
         co -> {
           co.withStopOnInformerErrorDuringStartup(stopOnInformerErrorDuringStartup);
-          co.withCacheSyncTimeout(3000);
+          co.withCacheSyncTimeout(Duration.ofMillis(3000));
           co.withInformerStoppedHandler((informer, ex) -> {
             stopHandlerCalled = true;
           });