Skip to content

Commit cbc470f

Browse files
committed
additional input validation
1 parent 9a19476 commit cbc470f

File tree

1 file changed

+7
-9
lines changed
  • operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing

1 file changed

+7
-9
lines changed

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/Controller.java

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,7 @@
1919
import io.javaoperatorsdk.operator.api.config.dependent.DependentResourceSpec;
2020
import io.javaoperatorsdk.operator.api.monitoring.Metrics;
2121
import io.javaoperatorsdk.operator.api.monitoring.Metrics.ControllerExecution;
22-
import io.javaoperatorsdk.operator.api.reconciler.Cleaner;
23-
import io.javaoperatorsdk.operator.api.reconciler.Context;
24-
import io.javaoperatorsdk.operator.api.reconciler.ContextInitializer;
25-
import io.javaoperatorsdk.operator.api.reconciler.DeleteControl;
26-
import io.javaoperatorsdk.operator.api.reconciler.EventSourceContext;
27-
import io.javaoperatorsdk.operator.api.reconciler.EventSourceInitializer;
28-
import io.javaoperatorsdk.operator.api.reconciler.Ignore;
29-
import io.javaoperatorsdk.operator.api.reconciler.Reconciler;
30-
import io.javaoperatorsdk.operator.api.reconciler.UpdateControl;
22+
import io.javaoperatorsdk.operator.api.reconciler.*;
3123
import io.javaoperatorsdk.operator.api.reconciler.dependent.Deleter;
3224
import io.javaoperatorsdk.operator.api.reconciler.dependent.DependentResource;
3325
import io.javaoperatorsdk.operator.api.reconciler.dependent.EventSourceProvider;
@@ -36,6 +28,8 @@
3628
import io.javaoperatorsdk.operator.api.reconciler.dependent.managed.ManagedDependentResourceException;
3729
import io.javaoperatorsdk.operator.processing.event.EventSourceManager;
3830

31+
import static io.javaoperatorsdk.operator.api.reconciler.Constants.WATCH_CURRENT_NAMESPACE;
32+
3933
@SuppressWarnings({"unchecked", "rawtypes"})
4034
@Ignore
4135
public class Controller<P extends HasMetadata>
@@ -332,6 +326,10 @@ private void validateCRDWithLocalModelIfRequired(Class<P> resClass, String contr
332326
}
333327

334328
public void changeNamespaces(Set<String> namespaces) {
329+
if (namespaces.contains(Constants.WATCH_ALL_NAMESPACES)
330+
|| namespaces.contains(WATCH_CURRENT_NAMESPACE)) {
331+
throw new OperatorException("Unexpected value in target namespaces: " + namespaces);
332+
}
335333
eventSourceManager.changeNamespaces(namespaces);
336334
}
337335

0 commit comments

Comments
 (0)