Skip to content

Commit a749b30

Browse files
committed
refactor: provide default empty implementation
1 parent 0c05521 commit a749b30

File tree

5 files changed

+1
-17
lines changed

5 files changed

+1
-17
lines changed

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/dependent/DependentResource.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ default Optional<ResourceEventSource<R, P>> eventSource(
4949
return Optional.empty();
5050
}
5151

52-
void useEventSourceWithName(String name);
52+
default void useEventSourceWithName(String name) {}
5353

5454
default Optional<R> getSecondaryResource(P primary, Context<P> context) {
5555
return Optional.empty();

operator-framework-core/src/test/java/io/javaoperatorsdk/operator/api/config/ControllerConfigurationOverriderTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,9 +80,6 @@ public ReconcileResult<Object> reconcile(ConfigMap primary, Context<ConfigMap> c
8080
public Class<Object> resourceType() {
8181
return Object.class;
8282
}
83-
84-
@Override
85-
public void useEventSourceWithName(String name) {}
8683
}
8784
}
8885

operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/dependent/AbstractDependentResourceTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,6 @@ public Class<ConfigMap> resourceType() {
7878
return ConfigMap.class;
7979
}
8080

81-
@Override
82-
public void useEventSourceWithName(String name) {}
83-
8481
@Override
8582
public Optional<ConfigMap> getSecondaryResource(TestCustomResource primary,
8683
Context<TestCustomResource> context) {

operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/dependent/EmptyTestDependentResource.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,5 @@ public ReconcileResult<Deployment> reconcile(TestCustomResource primary,
1919
public Class<Deployment> resourceType() {
2020
return Deployment.class;
2121
}
22-
23-
@Override
24-
public void useEventSourceWithName(String name) {}
25-
2622
}
2723

operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/dependent/workflow/AbstractWorkflowExecutorTest.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,6 @@ public Class<String> resourceType() {
4848
return String.class;
4949
}
5050

51-
@Override
52-
public void useEventSourceWithName(String name) {}
53-
5451
@Override
5552
public String toString() {
5653
return name;
@@ -110,9 +107,6 @@ public Class<String> resourceType() {
110107
return String.class;
111108
}
112109

113-
@Override
114-
public void useEventSourceWithName(String name) {}
115-
116110
@Override
117111
public String toString() {
118112
return name;

0 commit comments

Comments
 (0)