Skip to content

Commit a60cd31

Browse files
committed
tests: verify that remove is indeed called on the registry
1 parent b66712a commit a60cd31

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

micrometer-support/src/test/java/io/javaoperatorsdk/operator/monitoring/micrometer/MetricsCleaningOnDeleteIT.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import static org.assertj.core.api.Assertions.assertThat;
1919
import static org.awaitility.Awaitility.await;
2020
import static org.mockito.Mockito.mock;
21+
import static org.mockito.Mockito.verify;
2122

2223
public class MetricsCleaningOnDeleteIT {
2324
@RegisterExtension
@@ -62,6 +63,7 @@ void addsFinalizerAndCallsCleanupIfCleanerImplemented() {
6263
await().until(() -> operator.get(ConfigMap.class, testResourceName) == null);
6364

6465
await().atLeast(testDelay + 3, TimeUnit.SECONDS);
66+
meters.forEach(id -> verify(mockRegistry.remove(id)));
6567
meters = metrics.recordedMeterIdsFor(ResourceID.fromResource(created));
6668
assertThat(meters).isNull();
6769
}
@@ -82,7 +84,7 @@ public DeleteControl cleanup(ConfigMap resource, Context<ConfigMap> context) {
8284
private static class TestMetrics extends MicrometerMetrics {
8385

8486
public TestMetrics(MeterRegistry registry, int cleanUpDelayInSeconds) {
85-
super(registry, cleanUpDelayInSeconds);
87+
super(registry, cleanUpDelayInSeconds, 2);
8688
}
8789
}
8890
}

0 commit comments

Comments
 (0)