refactor: start isolating ResourceConfiguration

Author: metacosm

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/health/InformerWrappingEventSourceHealthIndicator.java

@@ -3,7 +3,6 @@
 import java.util.Map;
 
 import io.fabric8.kubernetes.api.model.HasMetadata;
-import io.javaoperatorsdk.operator.api.config.ResourceConfiguration;
 
 public interface InformerWrappingEventSourceHealthIndicator<R extends HasMetadata>
     extends EventSourceHealthIndicator {
@@ -17,6 +16,4 @@ default Status getStatus() {
 
     return nonUp.isPresent() ? Status.UNHEALTHY : Status.HEALTHY;
   }
-
-  ResourceConfiguration<R> getInformerConfiguration();
 }

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerEventSource.java

@@ -83,11 +83,12 @@ public InformerEventSource(
             .parseResourceVersionsForEventFilteringAndCaching());
   }
 
-  public InformerEventSource(InformerConfiguration<R> configuration, KubernetesClient client) {
+  InformerEventSource(InformerConfiguration<R> configuration, KubernetesClient client) {
     this(configuration, client, false);
   }
 
-  public InformerEventSource(InformerConfiguration<R> configuration,
+  @SuppressWarnings({"unchecked", "rawtypes"})
+  private InformerEventSource(InformerConfiguration<R> configuration,
       KubernetesClient client,
       boolean parseResourceVersions) {
     super(configuration.name(),

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerManager.java

@@ -28,7 +28,7 @@
 
 import static io.javaoperatorsdk.operator.api.reconciler.Constants.WATCH_ALL_NAMESPACES;
 
-public class InformerManager<R extends HasMetadata, C extends ResourceConfiguration<R>>
+class InformerManager<R extends HasMetadata, C extends ResourceConfiguration<R>>
     implements LifecycleAware, IndexerResourceCache<R> {
 
   private static final Logger log = LoggerFactory.getLogger(InformerManager.class);

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/ManagedInformerEventSource.java

@@ -174,11 +174,6 @@ public Status getStatus() {
     return InformerWrappingEventSourceHealthIndicator.super.getStatus();
   }
 
-  @Override
-  public ResourceConfiguration<R> getInformerConfiguration() {
-    return configuration();
-  }
-
   @Override
   public C configuration() {
     return configuration;

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/createupdateeventfilter/CreateUpdateEventFilterTestReconciler.java

@@ -96,9 +96,7 @@ public List<EventSource<?, CreateUpdateEventFilterTestCustomResource>> prepareEv
         InformerConfiguration.from(ConfigMap.class, CreateUpdateEventFilterTestCustomResource.class)
             .withLabelSelector("integrationtest = " + this.getClass().getSimpleName())
             .build();
-    final var informerEventSource =
-        new InformerEventSource<ConfigMap, CreateUpdateEventFilterTestCustomResource>(
-            informerConfiguration, context.getClient());
+    final var informerEventSource = new InformerEventSource<>(informerConfiguration, context);
     this.configMapDR.setEventSource(informerEventSource);
 
     return List.of(informerEventSource);