Skip to content

Commit 900c9fb

Browse files
authored
refactor: use fabric8 finalizer validation (#1142)
Fixes #1141
1 parent 94903fe commit 900c9fb

File tree

1 file changed

+1
-21
lines changed

1 file changed

+1
-21
lines changed

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/ReconcilerUtils.java

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import java.util.Locale;
88

99
import io.fabric8.kubernetes.api.model.HasMetadata;
10-
import io.fabric8.kubernetes.api.model.ObjectMeta;
1110
import io.fabric8.kubernetes.client.utils.Serialization;
1211
import io.javaoperatorsdk.operator.api.reconciler.Constants;
1312
import io.javaoperatorsdk.operator.api.reconciler.ControllerConfiguration;
@@ -23,26 +22,7 @@ public class ReconcilerUtils {
2322
private ReconcilerUtils() {}
2423

2524
public static boolean isFinalizerValid(String finalizer) {
26-
// todo: use fabric8 method when 5.12 is released
27-
// return HasMetadata.validateFinalizer(finalizer);
28-
final var validator = new HasMetadata() {
29-
30-
@Override
31-
public ObjectMeta getMetadata() {
32-
throw new UnsupportedOperationException();
33-
}
34-
35-
@Override
36-
public void setMetadata(ObjectMeta objectMeta) {
37-
throw new UnsupportedOperationException();
38-
}
39-
40-
@Override
41-
public void setApiVersion(String s) {
42-
throw new UnsupportedOperationException();
43-
}
44-
};
45-
return validator.isFinalizerValid(finalizer);
25+
return HasMetadata.validateFinalizer(finalizer);
4626
}
4727

4828
public static String getResourceTypeNameWithVersion(Class<? extends HasMetadata> resourceClass) {

0 commit comments

Comments
 (0)