refactor: do not use BooleanWithUndefined outside of annotations

Signed-off-by: Chris Laprun <claprun@redhat.com>

Author: metacosm

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentConverter.java

@@ -39,12 +39,11 @@ public KubernetesDependentResourceConfig<R> configFrom(KubernetesDependent confi
     var createResourceOnlyIfNotExistingWithSSA =
         DEFAULT_CREATE_RESOURCE_ONLY_IF_NOT_EXISTING_WITH_SSA;
 
-    BooleanWithUndefined useSSA = BooleanWithUndefined.UNDEFINED;
-
+    Boolean useSSA = null;
     if (configAnnotation != null) {
       createResourceOnlyIfNotExistingWithSSA =
           configAnnotation.createResourceOnlyIfNotExistingWithSSA();
-      useSSA = configAnnotation.useSSA();
+      useSSA = configAnnotation.useSSA().asBoolean();
     }
 
     var informerConfiguration = createInformerConfiguration(configAnnotation,

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResource.java

@@ -157,18 +157,16 @@ protected boolean useSSA(Context<P> context) {
     if (usingCustomResourceUpdateMatcher) {
       return false;
     }
-    var useSSAConfig =
-        configuration().map(KubernetesDependentResourceConfig::useSSA)
-            .orElse(BooleanWithUndefined.UNDEFINED);
+    var useSSAConfig = configuration()
+        .map(KubernetesDependentResourceConfig::useSSA)
+        .orElse(null);
     var configService = context.getControllerConfiguration().getConfigurationService();
     // don't use SSA for certain resources by default, only if explicitly overriden
-    if (BooleanWithUndefined.UNDEFINED.equals(useSSAConfig)
-        && configService.defaultNonSSAResource().contains(resourceType())) {
+    if (useSSAConfig == null && configService.defaultNonSSAResource().contains(resourceType())) {
       return false;
     }
-    return Optional.ofNullable(useSSAConfig.asBoolean())
-        .orElse(context.getControllerConfiguration().getConfigurationService()
-            .ssaBasedCreateUpdateMatchForDependentResources());
+    return Optional.ofNullable(useSSAConfig)
+        .orElse(configService.ssaBasedCreateUpdateMatchForDependentResources());
   }
 
   private boolean usePreviousAnnotation(Context<P> context) {

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResourceConfig.java

@@ -9,13 +9,12 @@ public class KubernetesDependentResourceConfig<R extends HasMetadata> {
 
   public static final boolean DEFAULT_CREATE_RESOURCE_ONLY_IF_NOT_EXISTING_WITH_SSA = true;
 
-  private final BooleanWithUndefined useSSA;
+  private final Boolean useSSA;
   private final boolean createResourceOnlyIfNotExistingWithSSA;
-
-  private InformerConfiguration<R> informerConfiguration;
+  private final InformerConfiguration<R> informerConfiguration;
 
   public KubernetesDependentResourceConfig(
-      BooleanWithUndefined useSSA,
+      Boolean useSSA,
       boolean createResourceOnlyIfNotExistingWithSSA,
       InformerConfiguration<R> informerConfiguration) {
     this.useSSA = useSSA;
@@ -27,7 +26,7 @@ public boolean createResourceOnlyIfNotExistingWithSSA() {
     return createResourceOnlyIfNotExistingWithSSA;
   }
 
-  public BooleanWithUndefined useSSA() {
+  public Boolean useSSA() {
     return useSSA;
   }
 

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResourceConfigBuilder.java

@@ -7,7 +7,7 @@
 public final class KubernetesDependentResourceConfigBuilder<R extends HasMetadata> {
 
   private boolean createResourceOnlyIfNotExistingWithSSA;
-  private BooleanWithUndefined useSSA = BooleanWithUndefined.UNDEFINED;
+  private Boolean useSSA = null;
 
   private InformerConfiguration<R> informerConfiguration;
 
@@ -23,7 +23,7 @@ public KubernetesDependentResourceConfigBuilder<R> withCreateResourceOnlyIfNotEx
     return this;
   }
 
-  public KubernetesDependentResourceConfigBuilder<R> withUseSSA(BooleanWithUndefined useSSA) {
+  public KubernetesDependentResourceConfigBuilder<R> withUseSSA(boolean useSSA) {
     this.useSSA = useSSA;
     return this;
   }

operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/dependentssa/DependentSSAReconciler.java

@@ -10,7 +10,6 @@
 import io.javaoperatorsdk.operator.api.reconciler.EventSourceUtils;
 import io.javaoperatorsdk.operator.api.reconciler.Reconciler;
 import io.javaoperatorsdk.operator.api.reconciler.UpdateControl;
-import io.javaoperatorsdk.operator.processing.dependent.kubernetes.BooleanWithUndefined;
 import io.javaoperatorsdk.operator.processing.dependent.kubernetes.KubernetesDependentResourceConfigBuilder;
 import io.javaoperatorsdk.operator.processing.event.source.EventSource;
 import io.javaoperatorsdk.operator.support.TestExecutionInfoProvider;
@@ -29,7 +28,7 @@ public DependentSSAReconciler() {
 
   public DependentSSAReconciler(boolean useSSA) {
     ssaConfigMapDependent.configureWith(new KubernetesDependentResourceConfigBuilder<ConfigMap>()
-        .withUseSSA(useSSA ? BooleanWithUndefined.TRUE : BooleanWithUndefined.FALSE)
+        .withUseSSA(useSSA)
         .build());
   }