Skip to content

Commit 72911d6

Browse files
committed
feat: logging in yaml format only in debug mode
Signed-off-by: 10000-ki <10000ki6472@gmail.com>
1 parent 2633cfd commit 72911d6

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/SSABasedGenericKubernetesResourceMatcher.java

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,14 +104,22 @@ public boolean matches(R actual, R desired, Context<?> context) {
104104
removeIrrelevantValues(desiredMap);
105105

106106
if (LoggingUtils.isNotSensitiveResource(desired)) {
107-
var actualYaml = objectMapper.asYaml(prunedActual);
108-
var desiredYaml = objectMapper.asYaml(desiredMap);
109-
log.debug("Pruned actual: \n {} \n desired: \n {} ", actualYaml, desiredYaml);
107+
logDiff(prunedActual, desiredMap, objectMapper);
110108
}
111109

112110
return prunedActual.equals(desiredMap);
113111
}
114112

113+
private void logDiff(Map<String, Object> prunedActualMap, Map<String, Object> desiredMap, KubernetesSerialization serialization) {
114+
if (log.isDebugEnabled()) {
115+
var actualYaml = serialization.asYaml(prunedActualMap);
116+
var desiredYaml = serialization.asYaml(desiredMap);
117+
log.debug("Pruned actual: \n {} \n desired: \n {} ", actualYaml, desiredYaml);
118+
} else {
119+
log.debug("Pruned actual: \n {} \n desired: \n {} ", prunedActualMap, desiredMap);
120+
}
121+
}
122+
115123
/**
116124
* Correct for known issue with SSA
117125
*/

0 commit comments

Comments
 (0)