Skip to content

Commit 71e5185

Browse files
metacosmcsviri
andauthored
fix: remove now unneeded okhttp dependency override, wrong comment (#2331)
Signed-off-by: Chris Laprun <claprun@redhat.com> Co-authored-by: Attila Mészáros <csviri@gmail.com>
1 parent 76046f7 commit 71e5185

File tree

1 file changed

+1
-10
lines changed

1 file changed

+1
-10
lines changed

pom.xml

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -200,15 +200,6 @@
200200
<artifactId>operator-framework</artifactId>
201201
<version>${project.version}</version>
202202
</dependency>
203-
<!--
204-
regarding the okhttp explicit version
205-
see https://github.com/fabric8io/kubernetes-client/issues/4290
206-
-->
207-
<dependency>
208-
<groupId>com.squareup.okhttp3</groupId>
209-
<artifactId>okhttp</artifactId>
210-
<version>${okhttp.version}</version>
211-
</dependency>
212203
<dependency>
213204
<groupId>com.squareup.okhttp3</groupId>
214205
<artifactId>logging-interceptor</artifactId>
@@ -231,6 +222,7 @@
231222
<scope>test</scope>
232223
</dependency>
233224
<!-- Kubernetes client HTTP client implementations -->
225+
<!-- Default implementation is controlled by fabric8-httpclient-impl.name property -->
234226
<dependency>
235227
<groupId>io.fabric8</groupId>
236228
<artifactId>kubernetes-httpclient-okhttp</artifactId>
@@ -241,7 +233,6 @@
241233
<artifactId>kubernetes-httpclient-vertx</artifactId>
242234
<version>${fabric8-client.version}</version>
243235
</dependency>
244-
<!-- We currently only recommend using the legacy okhttp client and the vert.x-based implementation -->
245236
<dependency>
246237
<groupId>io.fabric8</groupId>
247238
<artifactId>kubernetes-httpclient-jdk</artifactId>

0 commit comments

Comments
 (0)