refactor: create an instance just for testing isLastAttempt

Author: scrocquesel

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/ReconciliationDispatcher.java

@@ -165,19 +165,8 @@ private PostExecutionControl<P> handleErrorStatusHandler(P resource, P originalR
       Exception e) throws Exception {
     if (isErrorStatusHandlerPresent()) {
       try {
-        RetryInfo retryInfo = context.getRetryInfo().orElse(new RetryInfo() {
-          @Override
-          public int getAttemptCount() {
-            return 0;
-          }
-
-          @Override
-          public boolean isLastAttempt() {
-            // on first try, we can only rely on the configured behavior
-            // if enabled, will at least produce one RetryExecution
-            return !controller.getConfiguration().getRetry().enabled();
-          }
-        });
+        RetryInfo retryInfo =
+            context.getRetryInfo().orElse(controller.getConfiguration().getRetry().initExecution());
         ((DefaultContext<P>) context).setRetryInfo(retryInfo);
         var errorStatusUpdateControl = ((ErrorStatusHandler<P>) controller.getReconciler())
             .updateErrorStatus(resource, context, e);

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/retry/GenericRetry.java

@@ -92,11 +92,6 @@ public GenericRetry withLinearRetry() {
     return this;
   }
 
-  @Override
-  public boolean enabled() {
-    return this.maxAttempts > 0;
-  }
-
   @Override
   public void initFrom(GradualRetry configuration) {
     this.initialInterval = configuration.initialInterval();

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/retry/Retry.java

@@ -5,8 +5,4 @@ public interface Retry {
 
   RetryExecution initExecution();
 
-  default boolean enabled() {
-    return false;
-  }
-
 }