fix: smells

Author: csviri

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/workflow/DependsOnRelation.java

@@ -10,35 +10,23 @@ public class DependsOnRelation {
 
   public DependsOnRelation() {}
 
-  public DependsOnRelation(DependentResourceNode owner, DependentResourceNode dependsOn) {
+  public DependsOnRelation(DependentResourceNode<?, ?> owner,
+      DependentResourceNode<?, ?> dependsOn) {
     this(owner, dependsOn, null);
   }
 
-  public DependsOnRelation(DependentResourceNode owner, DependentResourceNode dependsOn,
+  public DependsOnRelation(DependentResourceNode<?, ?> owner, DependentResourceNode<?, ?> dependsOn,
       WaitCondition waitCondition) {
     this.owner = owner;
     this.dependsOn = dependsOn;
     this.waitCondition = waitCondition;
   }
 
-
-  public void setOwner(DependentResourceNode owner) {
-    this.owner = owner;
-  }
-
-  public void setDependsOn(DependentResourceNode dependsOn) {
-    this.dependsOn = dependsOn;
-  }
-
-  public void setWaitCondition(WaitCondition waitCondition) {
-    this.waitCondition = waitCondition;
-  }
-
   public DependentResourceNode<?, ?> getOwner() {
     return owner;
   }
 
-  public DependentResourceNode getDependsOn() {
+  public DependentResourceNode<?, ?> getDependsOn() {
     return dependsOn;
   }
 

operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/dependent/workflow/WorkflowTest.java

@@ -91,9 +91,8 @@ void exceptionHandlingSimpleCases() {
     var workflow = new WorkflowBuilder<TestCustomResource>()
         .addDependent(errorDR2).build()
         .build();
-    assertThrows(AggregatedOperatorException.class, () -> {
-      workflow.reconcile(new TestCustomResource(), null);
-    });
+    assertThrows(AggregatedOperatorException.class,
+        () -> workflow.reconcile(new TestCustomResource(), null));
     assertThat(executionHistory).notReconciled(errorDR2);
   }
 
@@ -104,9 +103,8 @@ void dependentsOnErroredResourceNotReconciled() {
         .addDependent(errorDR2).dependsOn(dr1).build()
         .addDependent(dr2).dependsOn(errorDR2).build()
         .build();
-    assertThrows(AggregatedOperatorException.class, () -> {
-      workflow.reconcile(new TestCustomResource(), null);
-    });
+    assertThrows(AggregatedOperatorException.class,
+        () -> workflow.reconcile(new TestCustomResource(), null));
 
     assertThat(executionHistory).reconciled(dr1).notReconciled(errorDR2, dr2);
   }
@@ -118,9 +116,8 @@ void onlyOneDependsOnErroredResourceNotReconciled() {
         .addDependent(errorDR2).build()
         .addDependent(dr2).dependsOn(errorDR2).dependsOn(dr1).build()
         .build();
-    assertThrows(AggregatedOperatorException.class, () -> {
-      workflow.reconcile(new TestCustomResource(), null);
-    });
+    assertThrows(AggregatedOperatorException.class,
+        () -> workflow.reconcile(new TestCustomResource(), null));
 
     assertThat(executionHistory).notReconciled(dr2);
   }