Skip to content

Commit 609b9b3

Browse files
metacosmcsviri
andcommitted
fix: remove now unneeded okhttp dependency override, wrong comment (#2331)
Signed-off-by: Chris Laprun <claprun@redhat.com> Co-authored-by: Attila Mészáros <csviri@gmail.com> Signed-off-by: Attila Mészáros <csviri@gmail.com>
1 parent 78ba837 commit 609b9b3

File tree

1 file changed

+1
-10
lines changed

1 file changed

+1
-10
lines changed

pom.xml

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -199,15 +199,6 @@
199199
<artifactId>operator-framework</artifactId>
200200
<version>${project.version}</version>
201201
</dependency>
202-
<!--
203-
regarding the okhttp explicit version
204-
see https://github.com/fabric8io/kubernetes-client/issues/4290
205-
-->
206-
<dependency>
207-
<groupId>com.squareup.okhttp3</groupId>
208-
<artifactId>okhttp</artifactId>
209-
<version>${okhttp.version}</version>
210-
</dependency>
211202
<dependency>
212203
<groupId>com.squareup.okhttp3</groupId>
213204
<artifactId>logging-interceptor</artifactId>
@@ -230,6 +221,7 @@
230221
<scope>test</scope>
231222
</dependency>
232223
<!-- Kubernetes client HTTP client implementations -->
224+
<!-- Default implementation is controlled by fabric8-httpclient-impl.name property -->
233225
<dependency>
234226
<groupId>io.fabric8</groupId>
235227
<artifactId>kubernetes-httpclient-okhttp</artifactId>
@@ -240,7 +232,6 @@
240232
<artifactId>kubernetes-httpclient-vertx</artifactId>
241233
<version>${fabric8-client.version}</version>
242234
</dependency>
243-
<!-- We currently only recommend using the legacy okhttp client and the vert.x-based implementation -->
244235
<dependency>
245236
<groupId>io.fabric8</groupId>
246237
<artifactId>kubernetes-httpclient-jdk</artifactId>

0 commit comments

Comments
 (0)