Skip to content

Commit 4597d20

Browse files
committed
compute diff only when actual doesn't match desired
1 parent 1196df8 commit 4597d20

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/SSABasedGenericKubernetesResourceMatcher.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,15 +105,17 @@ public boolean matches(R actual, R desired, Context<?> context) {
105105

106106
removeIrrelevantValues(desiredMap);
107107

108-
if (LoggingUtils.isNotSensitiveResource(desired)) {
108+
var matches = prunedActual.equals(desiredMap);
109+
110+
if (!matches && LoggingUtils.isNotSensitiveResource(desired)) {
109111
var diff = getDiff(prunedActual, desiredMap, objectMapper);
110112
if (diff != null) {
111113
log.debug("Diff between actual and desired state for resource: {} with name: {} in namespace: {} is: \n{}",
112114
actual.getKind(), actual.getMetadata().getName(), actual.getMetadata().getNamespace(), diff);
113115
}
114116
}
115117

116-
return prunedActual.equals(desiredMap);
118+
return matches;
117119
}
118120

119121
private String getDiff(Map<String, Object> prunedActualMap, Map<String, Object> desiredMap,

0 commit comments

Comments
 (0)