refactor: remove caching

metacosm · metacosm · commit 3ec19c5fe30c · 2024-07-04T14:54:06.000+02:00
Signed-off-by: Chris Laprun &lt;claprun@redhat.com&gt;
diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/workflow/WorkflowReconcileResult.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/workflow/WorkflowReconcileResult.java
@@ -8,7 +8,6 @@
 
 @SuppressWarnings("rawtypes")
 public class WorkflowReconcileResult extends WorkflowResult {
-  private Boolean allDependentsReady;
 
   WorkflowReconcileResult(Map<DependentResource, Detail<?>> results) {
     super(results);
@@ -28,9 +27,6 @@ public <T> Optional<T> getNotReadyDependentResult(DependentResource dependentRes
   }
 
   public boolean allDependentResourcesReady() {
-    if (allDependentsReady == null) {
-      allDependentsReady = getNotReadyDependents().isEmpty();
-    }
-    return allDependentsReady;
+    return getNotReadyDependents().isEmpty();
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,6 @@`
`8`	`8`
`9`	`9`	`@SuppressWarnings("rawtypes")`
`10`	`10`	`public class WorkflowReconcileResult extends WorkflowResult {`
`11`		`- private Boolean allDependentsReady;`
`12`	`11`
`13`	`12`	`WorkflowReconcileResult(Map<DependentResource, Detail<?>> results) {`
`14`	`13`	`super(results);`
`@@ -28,9 +27,6 @@ public <T> Optional<T> getNotReadyDependentResult(DependentResource dependentRes`
`28`	`27`	`}`
`29`	`28`
`30`	`29`	`public boolean allDependentResourcesReady() {`
`31`		`- if (allDependentsReady == null) {`
`32`		`- allDependentsReady = getNotReadyDependents().isEmpty();`
`33`		`- }`
`34`		`- return allDependentsReady;`
	`30`	`+ return getNotReadyDependents().isEmpty();`
`35`	`31`	`}`
`36`	`32`	`}`