Skip to content

Commit 3b0a8a7

Browse files
committed
test + docs
Signed-off-by: Attila Mészáros <csviri@gmail.com>
1 parent 8267b8c commit 3b0a8a7

File tree

2 files changed

+19
-8
lines changed

2 files changed

+19
-8
lines changed

docsy/content/en/docs/migration/v5-0-migration.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,4 +60,5 @@ description: Migrating from v4.7 to v5.0
6060
This also means, that `BulkDependentResource` now does not automatically implement `Creator` and `Deleter` as before.
6161
Make sure to implement those interfaces in your bulk dependent resources. You can use also the new helper interface, the
6262
[`CRUDBulkDependentResource`](https://github.com/operator-framework/java-operator-sdk/blob/main/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/CRUDBulkDependentResource.java)
63-
what also implement `BulkUpdater` interface.
63+
what also implement `BulkUpdater` interface.
64+
12. `@ControllerConfiguration` is optional

operator-framework/src/test/java/io/javaoperatorsdk/operator/config/BaseConfigurationServiceTest.java

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010
import java.util.Set;
1111
import java.util.concurrent.TimeUnit;
1212

13+
import io.javaoperatorsdk.operator.ReconcilerUtils;
14+
import io.javaoperatorsdk.operator.api.reconciler.*;
1315
import org.junit.jupiter.api.Test;
1416

1517
import io.fabric8.kubernetes.api.model.ConfigMap;
@@ -20,12 +22,6 @@
2022
import io.javaoperatorsdk.operator.api.config.dependent.Configured;
2123
import io.javaoperatorsdk.operator.api.config.dependent.DependentResourceConfigurationResolver;
2224
import io.javaoperatorsdk.operator.api.config.dependent.DependentResourceSpec;
23-
import io.javaoperatorsdk.operator.api.reconciler.Context;
24-
import io.javaoperatorsdk.operator.api.reconciler.ControllerConfiguration;
25-
import io.javaoperatorsdk.operator.api.reconciler.MaxReconciliationInterval;
26-
import io.javaoperatorsdk.operator.api.reconciler.Reconciler;
27-
import io.javaoperatorsdk.operator.api.reconciler.UpdateControl;
28-
import io.javaoperatorsdk.operator.api.reconciler.Workflow;
2925
import io.javaoperatorsdk.operator.api.reconciler.dependent.Dependent;
3026
import io.javaoperatorsdk.operator.api.reconciler.dependent.DependentResource;
3127
import io.javaoperatorsdk.operator.api.reconciler.dependent.ReconcileResult;
@@ -41,6 +37,8 @@
4137
import io.javaoperatorsdk.operator.processing.retry.RetryExecution;
4238
import io.javaoperatorsdk.operator.sample.readonly.ReadOnlyDependent;
4339

40+
import static io.javaoperatorsdk.operator.api.reconciler.MaxReconciliationInterval.DEFAULT_INTERVAL;
41+
import static org.assertj.core.api.Assertions.assertThat;
4442
import static org.junit.jupiter.api.Assertions.*;
4543

4644
class BaseConfigurationServiceTest {
@@ -122,8 +120,20 @@ void getDependentResources() {
122120
void missingAnnotationCreatesDefaultConfig() {
123121
final var reconciler = new MissingAnnotationReconciler();
124122
var config = configFor(reconciler);
125-
// todo asserts
126123

124+
assertThat(config.getName()).isEqualTo(ReconcilerUtils.getNameFor(reconciler));
125+
assertThat(config.getLabelSelector()).isEmpty();
126+
assertThat(config.getRetry()).isInstanceOf(GenericRetry.class);
127+
assertThat(config.getRateLimiter()).isInstanceOf(LinearRateLimiter.class);
128+
assertThat(config.maxReconciliationInterval()).hasValue(Duration.ofHours(DEFAULT_INTERVAL));
129+
assertThat(config.fieldManager()).isEqualTo(config.getName());
130+
assertThat(config.getInformerListLimit()).isEmpty();
131+
assertThat(config.onAddFilter()).isEmpty();
132+
assertThat(config.onUpdateFilter()).isEmpty();
133+
assertThat(config.genericFilter()).isEmpty();
134+
assertThat(config.getNamespaces()).isEqualTo(Constants.DEFAULT_NAMESPACES_SET);
135+
assertThat(config.getFinalizerName()).isEqualTo(ReconcilerUtils.getDefaultFinalizerName(config.getResourceClass()));
136+
assertThat(config.getItemStore()).isEmpty();
127137
}
128138

129139
@SuppressWarnings("rawtypes")

0 commit comments

Comments
 (0)