@@ -43,12 +43,33 @@ protected Logger logger() {
43
43
private synchronized <R > void handleReconcile (DependentResourceNode <R , P > dependentResourceNode ) {
44
44
log .debug ("Submitting for reconcile: {} primaryID: {}" , dependentResourceNode , primaryID );
45
45
46
- if (alreadyVisited (dependentResourceNode )
47
- || isExecutingNow (dependentResourceNode )
48
- || !allParentsReconciledAndReady (dependentResourceNode )
49
- || markedForDelete .contains (dependentResourceNode )
50
- || hasErroredParent (dependentResourceNode )) {
51
- log .debug ("Skipping submit of: {}, primaryID: {}" , dependentResourceNode , primaryID );
46
+ final var alreadyVisited = alreadyVisited (dependentResourceNode );
47
+ final var executingNow = isExecutingNow (dependentResourceNode );
48
+ final var isWaitingOnParents = !allParentsReconciledAndReady (dependentResourceNode );
49
+ final var isMarkedForDelete = markedForDelete .contains (dependentResourceNode );
50
+ final var hasErroredParent = hasErroredParent (dependentResourceNode );
51
+ if (alreadyVisited || executingNow || isMarkedForDelete || isWaitingOnParents
52
+ || hasErroredParent ) {
53
+ if (log .isDebugEnabled ()) {
54
+ final var causes = new ArrayList <String >();
55
+ if (alreadyVisited ) {
56
+ causes .add ("already visited" );
57
+ }
58
+ if (executingNow ) {
59
+ causes .add ("executing now" );
60
+ }
61
+ if (isMarkedForDelete ) {
62
+ causes .add ("marked for delete" );
63
+ }
64
+ if (isWaitingOnParents ) {
65
+ causes .add ("waiting on parents" );
66
+ }
67
+ if (hasErroredParent ) {
68
+ causes .add ("errored parent" );
69
+ }
70
+ log .debug ("Skipping submit of: {} primaryID: {} causes: {}" , dependentResourceNode ,
71
+ primaryID , String .join (", " , causes ));
72
+ }
52
73
return ;
53
74
}
54
75
@@ -71,12 +92,29 @@ private synchronized <R> void handleReconcile(DependentResourceNode<R, P> depend
71
92
private synchronized void handleDelete (DependentResourceNode dependentResourceNode ) {
72
93
log .debug ("Submitting for delete: {}" , dependentResourceNode );
73
94
74
- if (alreadyVisited (dependentResourceNode )
75
- || isExecutingNow (dependentResourceNode )
76
- || !markedForDelete .contains (dependentResourceNode )
77
- || !allDependentsDeletedAlready (dependentResourceNode )) {
78
- log .debug ("Skipping submit for delete of: {} primaryID: {} " , dependentResourceNode ,
79
- primaryID );
95
+ final var alreadyVisited = alreadyVisited (dependentResourceNode );
96
+ final var executingNow = isExecutingNow (dependentResourceNode );
97
+ final var isNotMarkedForDelete = !markedForDelete .contains (dependentResourceNode );
98
+ final var isWaitingOnDependents = !allDependentsDeletedAlready (dependentResourceNode );
99
+ if (alreadyVisited || executingNow || isNotMarkedForDelete || isWaitingOnDependents ) {
100
+ if (log .isDebugEnabled ()) {
101
+ final var causes = new ArrayList <String >();
102
+ if (alreadyVisited ) {
103
+ causes .add ("already visited" );
104
+ }
105
+ if (executingNow ) {
106
+ causes .add ("executing now" );
107
+ }
108
+ if (isNotMarkedForDelete ) {
109
+ causes .add ("not marked for delete" );
110
+ }
111
+ if (isWaitingOnDependents ) {
112
+ causes .add ("waiting on dependents" );
113
+ }
114
+ log .debug ("Skipping submit for delete of: {} primaryID: {} causes: {}" ,
115
+ dependentResourceNode ,
116
+ primaryID , String .join (", " , causes ));
117
+ }
80
118
return ;
81
119
}
82
120
0 commit comments