Skip to content

Commit 216582c

Browse files
committed
refactor: introduce IndexedResourceCache interface
Signed-off-by: Chris Laprun <claprun@redhat.com>
1 parent e2928bb commit 216582c

File tree

4 files changed

+14
-7
lines changed

4 files changed

+14
-7
lines changed

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/Context.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import io.javaoperatorsdk.operator.api.config.ControllerConfiguration;
1111
import io.javaoperatorsdk.operator.api.reconciler.dependent.managed.ManagedDependentResourceContext;
1212
import io.javaoperatorsdk.operator.processing.event.EventSourceRetriever;
13+
import io.javaoperatorsdk.operator.processing.event.source.IndexedResourceCache;
1314
import io.javaoperatorsdk.operator.processing.event.source.IndexerResourceCache;
1415

1516
public interface Context<P extends HasMetadata> {
@@ -51,5 +52,5 @@ <R> Optional<R> getSecondaryResource(Class<R> expectedType,
5152
* @return the {@link IndexerResourceCache} associated with the associated {@link Reconciler} for
5253
* this context
5354
*/
54-
IndexerResourceCache<P> getPrimaryCache();
55+
IndexedResourceCache<P> getPrimaryCache();
5556
}

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/DefaultContext.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
import io.javaoperatorsdk.operator.api.reconciler.dependent.managed.ManagedDependentResourceContext;
1414
import io.javaoperatorsdk.operator.processing.Controller;
1515
import io.javaoperatorsdk.operator.processing.event.EventSourceRetriever;
16-
import io.javaoperatorsdk.operator.processing.event.source.IndexerResourceCache;
16+
import io.javaoperatorsdk.operator.processing.event.source.IndexedResourceCache;
1717

1818
public class DefaultContext<P extends HasMetadata> implements Context<P> {
1919

@@ -42,7 +42,7 @@ public <T> Set<T> getSecondaryResources(Class<T> expectedType) {
4242
}
4343

4444
@Override
45-
public IndexerResourceCache<P> getPrimaryCache() {
45+
public IndexedResourceCache<P> getPrimaryCache() {
4646
return controller.getEventSourceManager().getControllerResourceEventSource();
4747
}
4848

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
package io.javaoperatorsdk.operator.processing.event.source;
2+
3+
import io.fabric8.kubernetes.api.model.HasMetadata;
4+
5+
import java.util.List;
6+
7+
public interface IndexedResourceCache<T extends HasMetadata> extends ResourceCache<T> {
8+
List<T> byIndex(String indexName, String indexKey);
9+
}

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/IndexerResourceCache.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,11 @@
66

77
import io.fabric8.kubernetes.api.model.HasMetadata;
88

9-
public interface IndexerResourceCache<T extends HasMetadata> extends ResourceCache<T> {
9+
public interface IndexerResourceCache<T extends HasMetadata> extends IndexedResourceCache<T> {
1010

1111
void addIndexers(Map<String, Function<T, List<String>>> indexers);
1212

1313
default void addIndexer(String name, Function<T, List<String>> indexer) {
1414
addIndexers(Map.of(name, indexer));
1515
}
16-
17-
List<T> byIndex(String indexName, String indexKey);
18-
1916
}

0 commit comments

Comments
 (0)