refactor: clean-up ResultCondition

Signed-off-by: Chris Laprun <claprun@redhat.com>

Author: metacosm

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/workflow/DefaultResult.java

@@ -0,0 +1,26 @@
+package io.javaoperatorsdk.operator.processing.dependent.workflow;
+
+public class DefaultResult<T> implements ResultCondition.Result<T> {
+  private final T result;
+  private final boolean success;
+
+  public DefaultResult(boolean success, T result) {
+    this.result = result;
+    this.success = success;
+  }
+
+  @Override
+  public T getResult() {
+    return result;
+  }
+
+  @Override
+  public boolean isSuccess() {
+    return success;
+  }
+
+  @Override
+  public String toString() {
+    return asString();
+  }
+}

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/workflow/ResultCondition.java

@@ -12,45 +12,20 @@ default boolean isMet(DependentResource<R, P> dependentResource, P primary, Cont
     return detailedIsMet(dependentResource, primary, context).isSuccess();
   }
 
+  @SuppressWarnings({"rawtypes", "unchecked"})
   interface Result<T> {
-    Result metWithoutResult = new Result() {
-      @Override
-      public Object getResult() {
-        return null;
-      }
-
-      @Override
-      public boolean isSuccess() {
-        return true;
-      }
-
-      @Override
-      public String toString() {
-        return asString();
-      }
-    };
-
-    Result unmetWithoutResult = new Result() {
-      @Override
-      public Object getResult() {
-        return null;
-      }
-
-      @Override
-      public boolean isSuccess() {
-        return false;
-      }
-
-      @Override
-      public String toString() {
-        return asString();
-      }
-    };
+    ResultCondition.Result metWithoutResult = new DefaultResult(true, null);
+
+    ResultCondition.Result unmetWithoutResult = new DefaultResult(false, null);
 
     static Result withoutResult(boolean success) {
       return success ? metWithoutResult : unmetWithoutResult;
     }
 
+    static <T> Result<T> withResult(boolean success, T result) {
+      return new DefaultResult<>(success, result);
+    }
+
     default String asString() {
       return "Result: " + getResult() + " met: " + isSuccess();
     }