Skip to content

Commit 19b31b0

Browse files
committed
review comments
1 parent 73889f9 commit 19b31b0

File tree

3 files changed

+14
-9
lines changed

3 files changed

+14
-9
lines changed

operator-framework-core/src/main/java-templates/io/javaoperatorsdk/operator/Versions.java

Lines changed: 0 additions & 8 deletions
This file was deleted.
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
package io.javaoperatorsdk.operator.api.config;
2+
3+
public final class Versions {
4+
5+
private Versions() {}
6+
7+
protected static final String JOSDK = "${project.version}";
8+
protected static final String KUBERNETES_CLIENT = "${fabric8-client.version}";
9+
10+
}

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/Version.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,10 @@
66
/** A class encapsulating the version information associated with this SDK instance. */
77
public class Version {
88

9-
public static final Version UNKNOWN = new Version("unknown", "unknown", Date.from(Instant.EPOCH));
9+
public static final Version UNKNOWN =
10+
new Version(Versions.JOSDK, "unknown", Date.from(Instant.EPOCH));
11+
public static final Version KUBENETES_CLIENT =
12+
new Version(Versions.KUBERNETES_CLIENT, "unknown", Date.from(Instant.EPOCH));
1013

1114
private final String sdk;
1215
private final String commit;

0 commit comments

Comments
 (0)