refactor: make AbstractEventSource fields private

Author: metacosm

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/AbstractEventSource.java

@@ -5,14 +5,18 @@
 
 public abstract class AbstractEventSource<P extends HasMetadata> implements EventSource<P> {
 
-  protected volatile EventHandler eventHandler;
-  protected volatile EventSourceRegistry<P> eventSourceRegistry;
+  private volatile EventHandler eventHandler;
+  private volatile EventSourceRegistry<P> eventSourceRegistry;
 
   @Override
   public void setEventHandler(EventHandler eventHandler) {
     this.eventHandler = eventHandler;
   }
 
+  protected EventHandler getEventHandler() {
+    return eventHandler;
+  }
+
   @Override
   public void setEventRegistry(EventSourceRegistry<P> registry) {
     this.eventSourceRegistry = registry;

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/AbstractResourceEventSource.java

@@ -54,7 +54,7 @@ protected abstract V wrapEventSource(
   void eventReceived(ResourceAction action, T resource, T oldResource) {
     log.debug("Event received for resource: {}", getName(resource));
     if (filter.acceptChange(configuration, oldResource, resource)) {
-      eventHandler.handleEvent(new ResourceEvent(action, ResourceID.fromResource(resource)));
+      getEventHandler().handleEvent(new ResourceEvent(action, ResourceID.fromResource(resource)));
     } else {
       log.debug(
           "Skipping event handling resource {} with version: {}",

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/InformerEventSource.java

@@ -84,7 +84,7 @@ public void onDelete(T t, boolean b) {
 
   private void propagateEvent(T object) {
     var primaryResourceIdSet =
-        associatedPrimaries.associatedPrimaryResources(object, eventSourceRegistry);
+        associatedPrimaries.associatedPrimaryResources(object, getEventRegistry());
     if (primaryResourceIdSet.isEmpty()) {
       return;
     }
@@ -95,8 +95,9 @@ private void propagateEvent(T object) {
        * automatically started, what would cause a NullPointerException here, since an event might
        * be received between creation and registration.
        */
+      final var eventHandler = getEventHandler();
       if (eventHandler != null) {
-        this.eventHandler.handleEvent(event);
+        eventHandler.handleEvent(event);
       }
     });
   }
@@ -123,7 +124,7 @@ public ResourceCache<T> getCache() {
    * @return the informed resource associated with the specified primary resource
    */
   public T getAssociated(P resource) {
-    return associatedWith.associatedSecondary(resource, eventSourceRegistry);
+    return associatedWith.associatedSecondary(resource, getEventRegistry());
   }
 
 }

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/TimerEventSource.java

@@ -70,7 +70,7 @@ public EventProducerTimeTask(ResourceID customResourceUid) {
     public void run() {
       if (running.get()) {
         log.debug("Producing event for custom resource id: {}", customResourceUid);
-        eventHandler.handleEvent(new Event(customResourceUid));
+        getEventHandler().handleEvent(new Event(customResourceUid));
       }
     }
   }