Skip to content

Commit 12d9e6b

Browse files
committed
refactor: rename created and updated more appropriately
1 parent 5e41a36 commit 12d9e6b

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/DependentResourceConfiguration.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@
1010
public interface DependentResourceConfiguration<R extends HasMetadata>
1111
extends ResourceConfiguration<R, DependentResourceConfiguration<R>> {
1212

13-
default boolean created() {
13+
default boolean creatable() {
1414
return true;
1515
}
1616

17-
default boolean updated() {
17+
default boolean updatable() {
1818
return false;
1919
}
2020

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/Controller.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,12 +77,12 @@ public UpdateControl<R> reconcile(R resource, Context context) {
7777
getDependentResources().forEach(dependent -> {
7878
final var conf = dependent.getConfiguration();
7979

80-
if (!conf.created() && !conf.updated()) {
80+
if (!conf.creatable() && !conf.updatable()) {
8181
return;
8282
}
8383

8484
var dependentResource = dependent.fetchFor(resource);
85-
if (conf.created() && dependentResource == null) {
85+
if (conf.creatable() && dependentResource == null) {
8686
// we need to create the dependent
8787
dependentResource = dependent.build();
8888

@@ -98,7 +98,7 @@ public UpdateControl<R> reconcile(R resource, Context context) {
9898
dependentResource.setMetadata(updatedMetadata);
9999
}
100100

101-
} else if (conf.updated()) {
101+
} else if (conf.updatable()) {
102102
dependentResource = dependent.update(dependentResource);
103103
}
104104

0 commit comments

Comments
 (0)