Skip to content

Commit 04846d9

Browse files
committed
refactor: DependentResourceConfigurator -> ConfiguredDependentResource
Signed-off-by: Chris Laprun <claprun@redhat.com>
1 parent be2a8e0 commit 04846d9

File tree

7 files changed

+13
-13
lines changed

7 files changed

+13
-13
lines changed

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/dependent/DependentResourceConfigurationResolver.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import io.javaoperatorsdk.operator.api.config.ControllerConfiguration;
99
import io.javaoperatorsdk.operator.api.config.Utils;
1010
import io.javaoperatorsdk.operator.api.reconciler.dependent.DependentResource;
11-
import io.javaoperatorsdk.operator.api.reconciler.dependent.managed.DependentResourceConfigurator;
11+
import io.javaoperatorsdk.operator.api.reconciler.dependent.managed.ConfiguredDependentResource;
1212

1313
@SuppressWarnings({"rawtypes", "unchecked"})
1414
public class DependentResourceConfigurationResolver {
@@ -22,7 +22,7 @@ private DependentResourceConfigurationResolver() {}
2222

2323
public static <C extends ControllerConfiguration<? extends HasMetadata>> void configure(
2424
DependentResource dependentResource, DependentResourceSpec spec, C parentConfiguration) {
25-
if (dependentResource instanceof DependentResourceConfigurator configurator) {
25+
if (dependentResource instanceof ConfiguredDependentResource configurator) {
2626
final var config = configurationFor(spec, parentConfiguration, dependentResource);
2727
configurator.configureWith(config);
2828
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import java.util.Optional;
44

5-
public interface DependentResourceConfigurator<C> {
5+
public interface ConfiguredDependentResource<C> {
66
void configureWith(C config);
77

88
Optional<C> configuration();

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResource.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import io.javaoperatorsdk.operator.api.reconciler.EventSourceContext;
2020
import io.javaoperatorsdk.operator.api.reconciler.Ignore;
2121
import io.javaoperatorsdk.operator.api.reconciler.dependent.GarbageCollected;
22-
import io.javaoperatorsdk.operator.api.reconciler.dependent.managed.DependentResourceConfigurator;
22+
import io.javaoperatorsdk.operator.api.reconciler.dependent.managed.ConfiguredDependentResource;
2323
import io.javaoperatorsdk.operator.processing.dependent.AbstractEventSourceHolderDependentResource;
2424
import io.javaoperatorsdk.operator.processing.dependent.Creator;
2525
import io.javaoperatorsdk.operator.processing.dependent.Matcher.Result;
@@ -35,7 +35,7 @@
3535
converter = KubernetesDependentConverter.class)
3636
public abstract class KubernetesDependentResource<R extends HasMetadata, P extends HasMetadata>
3737
extends AbstractEventSourceHolderDependentResource<R, P, InformerEventSource<R, P>>
38-
implements DependentResourceConfigurator<KubernetesDependentResourceConfig<R>> {
38+
implements ConfiguredDependentResource<KubernetesDependentResourceConfig<R>> {
3939

4040
private static final Logger log = LoggerFactory.getLogger(KubernetesDependentResource.class);
4141
private final boolean garbageCollected = this instanceof GarbageCollected;

operator-framework-core/src/test/java/io/javaoperatorsdk/operator/api/config/ControllerConfigurationOverriderTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
import io.javaoperatorsdk.operator.api.reconciler.dependent.DependentResource;
2323
import io.javaoperatorsdk.operator.api.reconciler.dependent.GarbageCollected;
2424
import io.javaoperatorsdk.operator.api.reconciler.dependent.ReconcileResult;
25-
import io.javaoperatorsdk.operator.api.reconciler.dependent.managed.DependentResourceConfigurator;
25+
import io.javaoperatorsdk.operator.api.reconciler.dependent.managed.ConfiguredDependentResource;
2626
import io.javaoperatorsdk.operator.processing.dependent.kubernetes.InformerConfig;
2727
import io.javaoperatorsdk.operator.processing.dependent.kubernetes.KubernetesDependent;
2828
import io.javaoperatorsdk.operator.processing.dependent.kubernetes.KubernetesDependentResource;
@@ -444,7 +444,7 @@ public NamedDependentResource() {
444444
}
445445

446446
private static class ExternalDependentResource implements DependentResource<Object, ConfigMap>,
447-
DependentResourceConfigurator<String>, GarbageCollected<ConfigMap> {
447+
ConfiguredDependentResource<String>, GarbageCollected<ConfigMap> {
448448

449449
private String config = "UNSET";
450450

operator-framework-core/src/test/java/io/javaoperatorsdk/operator/api/config/dependent/DependentResourceConfigurationResolverTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
import io.javaoperatorsdk.operator.api.reconciler.dependent.DependentResource;
2323
import io.javaoperatorsdk.operator.api.reconciler.dependent.GarbageCollected;
2424
import io.javaoperatorsdk.operator.api.reconciler.dependent.ReconcileResult;
25-
import io.javaoperatorsdk.operator.api.reconciler.dependent.managed.DependentResourceConfigurator;
25+
import io.javaoperatorsdk.operator.api.reconciler.dependent.managed.ConfiguredDependentResource;
2626
import io.javaoperatorsdk.operator.processing.dependent.kubernetes.KubernetesDependentConverter;
2727
import io.javaoperatorsdk.operator.processing.dependent.kubernetes.KubernetesDependentResource;
2828

@@ -181,7 +181,7 @@ public ServiceDep() {
181181
@Configured(by = CustomAnnotation.class, with = CustomConfig.class,
182182
converter = CustomConfigConverter.class)
183183
private static class CustomAnnotatedDep implements DependentResource<ConfigMap, ConfigMap>,
184-
DependentResourceConfigurator<CustomConfig>, GarbageCollected<ConfigMap> {
184+
ConfiguredDependentResource<CustomConfig>, GarbageCollected<ConfigMap> {
185185

186186
public static final int PROVIDED_VALUE = 42;
187187
private CustomConfig config;

operator-framework/src/test/java/io/javaoperatorsdk/operator/config/BaseConfigurationServiceTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
import io.javaoperatorsdk.operator.api.reconciler.dependent.Dependent;
3333
import io.javaoperatorsdk.operator.api.reconciler.dependent.DependentResource;
3434
import io.javaoperatorsdk.operator.api.reconciler.dependent.ReconcileResult;
35-
import io.javaoperatorsdk.operator.api.reconciler.dependent.managed.DependentResourceConfigurator;
35+
import io.javaoperatorsdk.operator.api.reconciler.dependent.managed.ConfiguredDependentResource;
3636
import io.javaoperatorsdk.operator.processing.dependent.kubernetes.CRUDKubernetesDependentResource;
3737
import io.javaoperatorsdk.operator.processing.dependent.kubernetes.KubernetesDependent;
3838
import io.javaoperatorsdk.operator.processing.dependent.kubernetes.KubernetesDependentResourceConfig;
@@ -452,7 +452,7 @@ public UpdateControl<ConfigMap> reconcile(ConfigMap resource, Context<ConfigMap>
452452
@Configured(by = CustomAnnotation.class, with = CustomConfig.class,
453453
converter = CustomConfigConverter.class)
454454
private static class CustomAnnotatedDep implements DependentResource<ConfigMap, ConfigMap>,
455-
DependentResourceConfigurator<CustomConfig> {
455+
ConfiguredDependentResource<CustomConfig> {
456456

457457
public static final int PROVIDED_VALUE = 42;
458458
private CustomConfig config;

sample-operators/mysql-schema/src/main/java/io/javaoperatorsdk/operator/sample/dependent/SchemaDependentResource.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
import io.javaoperatorsdk.operator.api.reconciler.Context;
2121
import io.javaoperatorsdk.operator.api.reconciler.dependent.Deleter;
2222
import io.javaoperatorsdk.operator.api.reconciler.dependent.DependentResource;
23-
import io.javaoperatorsdk.operator.api.reconciler.dependent.managed.DependentResourceConfigurator;
23+
import io.javaoperatorsdk.operator.api.reconciler.dependent.managed.ConfiguredDependentResource;
2424
import io.javaoperatorsdk.operator.processing.dependent.Creator;
2525
import io.javaoperatorsdk.operator.processing.dependent.external.PerResourcePollingDependentResource;
2626
import io.javaoperatorsdk.operator.sample.MySQLDbConfig;
@@ -40,7 +40,7 @@
4040
converter = ResourcePollerConfigConverter.class)
4141
public class SchemaDependentResource
4242
extends PerResourcePollingDependentResource<Schema, MySQLSchema>
43-
implements DependentResourceConfigurator<ResourcePollerConfig>,
43+
implements ConfiguredDependentResource<ResourcePollerConfig>,
4444
Creator<Schema, MySQLSchema>, Deleter<MySQLSchema> {
4545

4646
public static final String NAME = "schema";

0 commit comments

Comments
 (0)