bugfix: we might try sending the response header again in ngx.exit() when the header was already sent.

Author: agentzh

src/ngx_http_lua_util.c

@@ -2324,6 +2324,21 @@ ngx_http_lua_handle_exit(lua_State *L, ngx_http_request_t *r,
         }
     }
 
+#if 1
+    if (r->header_sent
+        && ctx->exit_code > NGX_OK
+        && ctx->exit_code != NGX_HTTP_REQUEST_TIME_OUT
+        && ctx->exit_code != NGX_HTTP_CLIENT_CLOSED_REQUEST
+        && ctx->exit_code != NGX_HTTP_CLOSE)
+    {
+        if (ctx->entered_content_phase) {
+            return NGX_OK;
+        }
+
+        return NGX_HTTP_OK;
+    }
+#endif
+
     return ctx->exit_code;
 }
 

t/005-exit.t

@@ -617,3 +617,23 @@ GET /lua HTTP/1.0
 lua sending HTTP 1.0 response headers
 [error]
 
+
+
+=== TEST 20: exit(201) with custom response body
+--- config
+    location = /t {
+        content_by_lua "
+            ngx.status = 201
+            ngx.say('ok');
+            return ngx.exit(201)
+        ";
+    }
+--- request
+    GET /t
+--- ignore_response
+--- log_level: debug
+--- no_error_log
+lua sending HTTP 1.0 response headers
+[error]
+[alert]
+

t/023-rewrite/uthread-exit.t

@@ -9,7 +9,7 @@ our $StapScript = $t::StapThread::StapScript;
 
 repeat_each(2);
 
-plan tests => repeat_each() * (blocks() * 4);
+plan tests => repeat_each() * (blocks() * 4 + 1);
 
 $ENV{TEST_NGINX_RESOLVER} ||= '8.8.8.8';
 $ENV{TEST_NGINX_MEMCACHED_PORT} ||= '11211';
@@ -171,6 +171,7 @@ hello in thread
 after
 --- no_error_log
 [error]
+[alert]