Skip to content

Commit 23e69fb

Browse files
spacewanderagentzh
authored andcommitted
bugfix: ngx_http_lua_ffi_ssl_set_serialized_session(): avoided memory leak when calling it repeatly.
Signed-off-by: Yichun Zhang (agentzh) <agentzh@gmail.com>
1 parent 5cd103b commit 23e69fb

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

src/ngx_http_lua_ssl_session_fetchby.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -567,6 +567,7 @@ ngx_http_lua_ffi_ssl_set_serialized_session(ngx_http_request_t *r,
567567
ngx_ssl_conn_t *ssl_conn;
568568
ngx_connection_t *c;
569569
ngx_ssl_session_t *session = NULL;
570+
ngx_ssl_session_t *old_session;
570571
ngx_http_lua_ssl_ctx_t *cctx;
571572

572573
c = r->connection;
@@ -597,8 +598,13 @@ ngx_http_lua_ffi_ssl_set_serialized_session(ngx_http_request_t *r,
597598
return NGX_ERROR;
598599
}
599600

601+
old_session = cctx->session;
600602
cctx->session = session;
601603

604+
if (old_session != NULL) {
605+
ngx_ssl_free_session(old_session);
606+
}
607+
602608
return NGX_OK;
603609
}
604610

0 commit comments

Comments
 (0)