Merge branch 'main' into rs/transform-named-capture-groups

Author: orinokai

.eslintignore

@@ -6,4 +6,5 @@ demos
 packages/runtime/src/templates/edge
 packages/runtime/src/templates/edge-shared
 packages/runtime/lib
-packages/runtime/dist-types
+packages/runtime/dist-types
+jestSetup.js

.eslintrc.js

@@ -46,6 +46,7 @@ module.exports = {
         // TODO: re-enable after dropping support for Node 12
         'n/no-unsupported-features/es-syntax': 'off',
         '@typescript-eslint/no-extra-semi': 'off',
+        'n/no-missing-import': 'off',
       },
     },
     {

.github/pull_request_template.md

@@ -1,3 +1,5 @@
+<!-- Before opening a pull request, ensure you've read our contributing guildines, https://github.com/netlify/next-runtime/blob/main/CONTRIBUTING.md. -->
+
 ### Summary
 
 <!-- Provide a brief summary of the change. -->

CONTRIBUTING.md

@@ -2,12 +2,14 @@
 
 🎉 Thanks for considering contributing to this project! 🎉
 
-These guidelines will help you send a pull request.
+When contributing to this repository, please first discuss the change you wish to make via an
+[issue](https://github.com/netlify/next-runtime/issues/new/choose). Please use the issue templates. They are there to
+help you and to help the maintainers gather information.
 
-If you're submitting an issue instead, please skip this document.
+Before working on an issue, ask to be assigned to it. This makes it clear to other potential contributors that someone
+is working on the issue.
 
-If your pull request is related to a typo or the documentation being unclear, please click on the relevant page's `Edit`
-button (pencil icon) and directly suggest a correction instead.
+When creating a PR, please use the template. The information in the template helps maintainers review your pull request.```
 
 This project was made with ❤️. The simplest way to give back is by starring and sharing it online.
 
@@ -37,9 +39,9 @@ We use [Conventional Commit messages](https://www.conventionalcommits.org/) to a
 
 Most common commit message prefixes are:
 
-* `fix:` which represents bug fixes, and generate a patch release.
-* `feat:` which represents a new feature, and generate a minor release.
-* `feat!:`, `fix!:` or `refactor!:` and generate a major release.
+- `fix:` which represents bug fixes, and generate a patch release.
+- `feat:` which represents a new feature, and generate a minor release.
+- `feat!:`, `fix!:` or `refactor!:` and generate a major release.
 
 ## Releasing
 

README.md

@@ -44,7 +44,7 @@ by targeting the `/_next/image/*` route:
 
 ## Disabling included image loader
 
-If you wish to disable the use of the image loader which is bundled into the runtime by default, set the `DISABLE_IPX` environment variable to `true`. 
+If you wish to disable the use of the image loader which is bundled into the runtime by default, set the `DISABLE_IPX` environment variable to `true`.
 
 This should only be done if the site is not using `next/image` or is using a different loader (such as Cloudinary or Imgix).
 
@@ -60,7 +60,7 @@ For more details on Next.js Middleware with Netlify, see the [middleware docs](h
 
 ### Limitations
 
-Due to how the site configuration is handled when it's run using Netlify Edge Functions, data such as `locale` and `defaultLocale` will be missing on the `req.nextUrl` object when running `netlify dev`. 
+Due to how the site configuration is handled when it's run using Netlify Edge Functions, data such as `locale` and `defaultLocale` will be missing on the `req.nextUrl` object when running `netlify dev`.
 
 However, this data is available on `req.nextUrl` in a production environment.
 
@@ -107,7 +107,15 @@ Edge runtime or middleware is enabled it will also generate edge functions for m
 
 ## Manually installing the Next.js Runtime
 
-The Next.js Runtime installs automatically for new Next.js sites on Netlify. You can also install it manually like this:
+The Next.js Runtime installs automatically for new Next.js sites on Netlify. You can also install it manually in the
+following ways:
+
+### From the UI (Recommended):
+
+You can go to the [UI](https://app.netlify.com/plugins/@netlify/plugin-nextjs/install) and choose the site to install the Next.js Runtime on. This method
+is recommended because you will benefit from auto-upgrades to important fixes and feature updates.
+
+### From `npm`:
 
 ```shell
 npm install -D @netlify/plugin-nextjs
@@ -117,9 +125,11 @@ npm install -D @netlify/plugin-nextjs
 
 ```toml
 [[plugins]]
-package = "@netlify/plugin-nextjs"
+  package = "@netlify/plugin-nextjs"
 ```
 
+This method is recommended if you wish to pin the Next.js Runtime to a specific version.
+
 ## Manually upgrading from an older version of the Next.js Runtime
 
 If you previously set these values, they're no longer needed and should be removed:
@@ -139,7 +149,7 @@ information on changes to how they are handled in this version. In particular, n
 files must be placed in `public`, not in the root of the site.
 
 ## Using with pnpm
-If your site uses pnpm to manage dependencies, currently you must [enable public hoisting](https://pnpm.io/npmrc#public-hoist-pattern). 
+If your site uses pnpm to manage dependencies, currently you must [enable public hoisting](https://pnpm.io/npmrc#public-hoist-pattern).
 The simplest way to do this is to create a `.npmrc` file in the root of your project with the content:
 
 ```ini

cypress/integration/middleware/enhanced.spec.ts

@@ -36,4 +36,16 @@ describe('Enhanced middleware', () => {
       expect(response.body).to.have.nested.property('headers.x-geo-timezone')
     })
   })
+
+  it('handles uppercase i18n redirects properly ', () => {
+    cy.visit('/de-DE/static')
+    cy.get('#message').contains('This was static but has been transformed in')
+    cy.contains("This is an ad that isn't shown by default")
+  })
+
+  it('handles lowercase i18n redirects properly ', () => {
+    cy.visit('/de-de/static')
+    cy.get('#message').contains('This was static but has been transformed in')
+    cy.contains("This is an ad that isn't shown by default")
+  })
 })

demos/base-path/package.json

@@ -3,6 +3,7 @@
   "version": "1.0.0",
   "description": "",
   "devDependencies": {
+    "@netlify/next": "*",
     "@netlify/plugin-nextjs": "*",
     "@types/fs-extra": "^9.0.13",
     "@types/jest": "^27.4.1",

demos/canary/package-lock.json

@@ -14,6 +14,7 @@
     "react-dom": "^18.2.0"
   },
   "devDependencies": {
+    "@netlify/next": "*",
     "@netlify/plugin-nextjs": "*",
     "@types/fs-extra": "^9.0.13",
     "@types/jest": "^27.4.1",

demos/canary/package.json

@@ -3,6 +3,7 @@
   "version": "1.0.0",
   "description": "",
   "devDependencies": {
+    "@netlify/next": "*",
     "@netlify/plugin-nextjs": "*",
     "@types/fs-extra": "^9.0.13",
     "@types/jest": "^27.4.1",

demos/custom-routes/package.json

@@ -21,12 +21,13 @@
     "@netlify/next": "*",
     "@reach/dialog": "^0.16.2",
     "@reach/visually-hidden": "^0.16.0",
-    "@vercel/og": "^0.0.20",
+    "@vercel/og": "^0.0.21",
     "next": "^13.0.3",
     "react": "^18.2.0",
     "react-dom": "^18.2.0"
   },
   "devDependencies": {
+    "@netlify/next": "*",
     "@netlify/plugin-nextjs": "*",
     "@types/fs-extra": "^9.0.13",
     "@types/jest": "^27.4.1",

demos/default/package.json

@@ -1,6 +1,9 @@
 import { NextResponse } from 'next/server'
 import { MiddlewareRequest, NextRequest } from '@netlify/next'
 
+// Next.js replaces this with a stub polyfill. This import is just to test that stub.
+import pointlessFetch from 'isomorphic-unfetch'
+
 export async function middleware(req: NextRequest) {
   let response
   const { pathname } = req.nextUrl
@@ -58,6 +61,12 @@ export async function middleware(req: NextRequest) {
   }
 
   if (pathname.startsWith('/shows')) {
+    if (pathname.startsWith('/shows/222')) {
+      response = NextResponse.next()
+      const res = await pointlessFetch('http://www.example.com/')
+      response.headers.set('x-example-server', res.headers.get('server'))
+    }
+
     if (pathname.startsWith('/shows/rewrite-absolute')) {
       response = NextResponse.rewrite(new URL('/shows/100', req.url))
       response.headers.set('x-modified-in-rewrite', 'true')

demos/middleware/middleware.ts

@@ -9,7 +9,7 @@ const nextConfig = {
   generateBuildId: () => 'build-id',
   i18n: {
     defaultLocale: 'en',
-    locales: ['en'],
+    locales: ['en', 'de-DE'],
   },
 }
 

demos/middleware/next.config.js

@@ -11,6 +11,7 @@
   "dependencies": {
     "@netlify/next": "*",
     "@netlify/plugin-nextjs": "*",
+    "isomorphic-unfetch": "^3.1.0",
     "next": "^13.0.3",
     "react": "^18.2.0",
     "react-dom": "^18.2.0"
@@ -24,4 +25,4 @@
     "npm-run-all": "^4.1.5",
     "typescript": "^4.6.3"
   }
-}
+}

demos/middleware/package.json

@@ -30,6 +30,7 @@
     "react-dom": "^18.2.0"
   },
   "devDependencies": {
+    "@netlify/next": "*",
     "@netlify/plugin-nextjs": "*",
     "@types/fs-extra": "^9.0.13",
     "@types/jest": "^27.4.1",

demos/next-auth/package.json

@@ -6,6 +6,7 @@
     "next": "^13.0.3"
   },
   "devDependencies": {
+    "@netlify/next": "*",
     "@netlify/plugin-nextjs": "*",
     "@types/fs-extra": "^9.0.13",
     "@types/jest": "^27.4.1",