test: update test to use Deno style of testing

include github workflow

Author: ericapisani

.github/workflows/test-deno.yml

@@ -0,0 +1,21 @@
+name: Deno tests
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+    branches: [main]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Git Checkout Deno Module
+        uses: actions/checkout@v2
+      - name: Use Deno Version ${{ matrix.deno-version }}
+        uses: denolib/setup-deno@v2
+        with:
+          deno-version: vx.x.x
+      - name: Test Deno
+        run: deno test packages/runtime/src/templates/edge-shared/

package.json

@@ -17,7 +17,8 @@
     "build": "npm run build -w packages/next -w packages/runtime",
     "postinstall": "run-s build install-husky",
     "install-husky": "if-env CI=1 || husky install node_modules/@netlify/eslint-config-node/.husky",
-    "test": "run-s build:demo test:jest",
+    "test": "run-s build:demo test:jest test:deno",
+    "test:deno": "deno test packages/runtime/src/templates/edge-shared/",
     "test:next": "jest -c test/e2e/jest.config.js",
     "test:next:disabled": "RUN_SKIPPED_TESTS=1 jest -c test/e2e/jest.config.disabled.js",
     "test:next:all": "RUN_SKIPPED_TESTS=1 jest -c test/e2e/jest.config.all.js",
@@ -101,11 +102,9 @@
       "**/test/**/*.spec.ts",
       "!**/test/e2e/**",
       "!**/test/fixtures/**",
-      "!**/test/sample/**"
+      "!**/test/sample/**",
+      "!**/test/templates/edge-shared/**"
     ],
-    "moduleNameMapper": {
-      "https://deno.land/x/html_rewriter@v0.1.0-pre.17": "<rootDir>/test/mockedDenoModules/html_rewriter"
-    },
     "transform": {
       "\\.[jt]sx?$": "babel-jest"
     },

test/templates/edge-shared/utils.spec.ts renamed to packages/runtime/src/templates/edge-shared/utils.test.ts

@@ -1,4 +1,11 @@
-import {updateModifiedHeaders, FetchEventResult} from '../../../packages/runtime/src/templates/edge-shared/utils'
+import { assertEquals } from 'https://deno.land/std@0.167.0/testing/asserts.ts'
+import {
+  beforeEach,
+  describe,
+  it,
+} from "https://deno.land/std@0.167.0/testing/bdd.ts";
+import {updateModifiedHeaders, FetchEventResult} from './utils.ts'
+
 
 describe('updateModifiedHeaders', () => {
   it('does not modify the headers if \'x-middleware-override-headers\' is not found', () => {
@@ -7,14 +14,14 @@ describe('updateModifiedHeaders', () => {
     // been modified with 'x-middleware-request' added to it, this is more to confirm the test case
     mockHeaders.set('x-middleware-request-foo', 'bar')
 
-    let mockResult: FetchEventResult = {
+    const mockResult: FetchEventResult = {
       response: new Response('', {headers: mockHeaders}),
       waitUntil: Promise.resolve()
     }
 
     mockResult.response = updateModifiedHeaders(mockResult.response)
 
-    expect(mockResult.response.headers.get('x-middleware-request-foo')).toEqual('bar')
+    assertEquals(mockResult.response.headers.get('x-middleware-request-foo'), 'bar')
   })
 
   describe('when the \'x-middleware-override-headers\' headers is present', () => {
@@ -38,19 +45,19 @@ describe('updateModifiedHeaders', () => {
     })
 
     it('does not modify headers that are missing \'x-middleware-request\' in the name', () => {
-      expect(mockResult.response.headers.get('foo')).toEqual('bar')
+      assertEquals(mockResult.response.headers.get('foo'), 'bar')
     })
 
     it('removes \'x-middleware-request-\' from headers', () => {
-      expect(mockResult.response.headers.get('x-middleware-request-hello')).toBe(null)
-      expect(mockResult.response.headers.get('x-middleware-request-test')).toBe(null)
+      assertEquals(mockResult.response.headers.get('x-middleware-request-hello'), null)
+      assertEquals(mockResult.response.headers.get('x-middleware-request-test'), null)
 
-      expect(mockResult.response.headers.get('hello')).toEqual('world')
-      expect(mockResult.response.headers.get('test')).toEqual('123')
+      assertEquals(mockResult.response.headers.get('hello'), 'world')
+      assertEquals(mockResult.response.headers.get('test'), '123')
     })
 
     it('removes \'x-middleware-override-headers\' after cleaning headers', () => {
-      expect(mockResult.response.headers.get('x-middleware-override-headers')).toBe(null)
+      assertEquals(mockResult.response.headers.get('x-middleware-override-headers'), null)
     })
   })
 })

packages/runtime/src/templates/edge-shared/utils.ts

@@ -67,13 +67,13 @@ function isMiddlewareResponse(response: Response | MiddlewareResponse): response
 // * https://github.com/vercel/next.js/blob/68d06fe015b28d8f81da52ca107a5f4bd72ab37c/packages/next/server/next-server.ts#L1918-L1928
 // * https://github.com/vercel/next.js/blob/43c9d8940dc42337dd2f7d66aa90e6abf952278e/packages/next/server/web/spec-extension/response.ts#L10-L27
 export function updateModifiedHeaders(response: Response) {
-  const overriddenHeaders = response.headers.get('x-middleware-override-headers') || ''
+  const overriddenHeaders = response.headers.get('x-middleware-override-headers')
 
   if (!overriddenHeaders) {
     return response
   }
 
-  const headersToUpdate = overriddenHeaders.split(',')
+  const headersToUpdate = overriddenHeaders.split(',').map(header => header.trim())
 
   for (const header of headersToUpdate) {
     const oldHeaderKey = 'x-middleware-request-' + header