fix: bypass handler function for non-prerendered dynamic routes with fallback: false

orinokai · orinokai · commit 1834fd0393a9 · 2022-08-16T17:31:24.000+01:00
diff --git a/packages/runtime/src/helpers/redirects.ts b/packages/runtime/src/helpers/redirects.ts
@@ -195,9 +195,10 @@ const generateDynamicRewrites = ({
       return
     }
     if (route.page in prerenderedDynamicRoutes) {
+      const { fallback } = prerenderedDynamicRoutes[route.page]
       if (matchesMiddleware(middleware, route.page)) {
         dynamicRoutesThatMatchMiddleware.push(route.page)
-      } else {
+      } else if (fallback !== false) {
         dynamicRewrites.push(
           ...redirectsForNextRoute({ buildId, route: route.page, basePath, to: ODB_FUNCTION_PATH, status: 200, i18n }),
         )

Original file line number	Diff line number	Diff line change
`@@ -195,9 +195,10 @@ const generateDynamicRewrites = ({`
`195`	`195`	`return`
`196`	`196`	`}`
`197`	`197`	`if (route.page in prerenderedDynamicRoutes) {`
	`198`	`+ const { fallback } = prerenderedDynamicRoutes[route.page]`
`198`	`199`	`if (matchesMiddleware(middleware, route.page)) {`
`199`	`200`	`dynamicRoutesThatMatchMiddleware.push(route.page)`
`200`		`- } else {`
	`201`	`+ } else if (fallback !== false) {`
`201`	`202`	`dynamicRewrites.push(`
`202`	`203`	`...redirectsForNextRoute({ buildId, route: route.page, basePath, to: ODB_FUNCTION_PATH, status: 200, i18n }),`
`203`	`204`	`)`