chore: fal build if edge disabled with edge runtime

Author: ascorbic

packages/runtime/src/helpers/edge.ts

@@ -182,7 +182,7 @@ export const writeEdgeFunctions = async (netlifyConfig: NetlifyConfig) => {
   await writeJson(join(edgeFunctionRoot, 'manifest.json'), manifest)
 }
 
-export const updateConfig = async (publish: string) => {
+export const enableEdgeInNextConfig = async (publish: string) => {
   const configFile = join(publish, 'required-server-files.json')
   const config = await readJSON(configFile)
   // This is for runtime in Next.js, rather than a build plugin setting

packages/runtime/src/index.ts

@@ -2,7 +2,7 @@
 import { join, relative } from 'path'
 
 import type { NetlifyPlugin } from '@netlify/build'
-import { greenBright, yellowBright, bold } from 'chalk'
+import { greenBright, bold, redBright } from 'chalk'
 import { existsSync, readFileSync } from 'fs-extra'
 import { outdent } from 'outdent'
 
@@ -15,7 +15,7 @@ import {
   configureHandlerFunctions,
   generateCustomHeaders,
 } from './helpers/config'
-import { updateConfig, writeEdgeFunctions, loadMiddlewareManifest } from './helpers/edge'
+import { enableEdgeInNextConfig, writeEdgeFunctions, loadMiddlewareManifest } from './helpers/edge'
 import { moveStaticPages, movePublicFiles, patchNextFiles } from './helpers/files'
 import { generateFunctions, setupImageFunction, generatePagesResolver } from './helpers/functions'
 import { generateRedirects, generateStaticRedirects } from './helpers/redirects'
@@ -80,6 +80,34 @@ const plugin: NetlifyPlugin = {
       },
     )
 
+    const middlewareManifest = await loadMiddlewareManifest(netlifyConfig)
+
+    let usingEdge = false
+
+    if (Object.keys(middlewareManifest?.functions).length !== 0) {
+      usingEdge = true
+      if (process.env.NEXT_DISABLE_NETLIFY_EDGE) {
+        failBuild(outdent`
+          You are using Next.js experimental edge runtime, but have set NEXT_DISABLE_NETLIFY_EDGE to true. This is not supported.
+          To use edge runtime, remove the env var ${bold`NEXT_DISABLE_NETLIFY_EDGE`}.
+        `)
+      }
+    }
+
+    if (Object.keys(middlewareManifest?.middleware).length !== 0) {
+      usingEdge = true
+      if (process.env.NEXT_DISABLE_NETLIFY_EDGE) {
+        console.log(
+          redBright(outdent`
+            You are using Next.js Middleware without Netlify Edge Functions.
+            This is deprecated because it negatively affects performance and will disable ISR and static rendering.
+            It also disables advanced middleware features from @netlify/next
+            To get the best performance and use Netlify Edge Functions, remove the env var ${bold`NEXT_DISABLE_NETLIFY_EDGE`}.
+          `),
+        )
+      }
+    }
+
     if (experimental.images) {
       experimentalRemotePatterns = experimental.images.remotePatterns || []
     }
@@ -138,32 +166,15 @@ const plugin: NetlifyPlugin = {
       buildId,
     })
 
-    if (!process.env.NEXT_DISABLE_NETLIFY_EDGE) {
+    if (usingEdge) {
       await writeEdgeFunctions(netlifyConfig)
 
-      await updateConfig(publish)
-    }
+      await enableEdgeInNextConfig(publish)
 
-    const middlewareManifest = await loadMiddlewareManifest(netlifyConfig)
-    if (
-      Object.keys(middlewareManifest?.middleware).length !== 0 ||
-      Object.keys(middlewareManifest?.functions).length !== 0
-    ) {
-      if (process.env.NEXT_DISABLE_NETLIFY_EDGE) {
-        console.log(
-          yellowBright(outdent`
-            You are using Next.js Middleware without Netlify Edge Functions.
-            This is deprecated because it negatively affects performance and will disable ISR and static rendering.
-            It also disables advanced middleware features from @netlify/next
-            To get the best performance and use Netlify Edge Functions, remove the env var ${bold`NEXT_DISABLE_NETLIFY_EDGE`}.
-          `),
-        )
-      } else {
-        console.log(outdent`
-          ✨ Deploying middleware and functions to ${greenBright`Netlify Edge Functions`} ✨
-          This feature is in beta. Please share your feedback here: https://ntl.fyi/next-netlify-edge
-        `)
-      }
+      console.log(outdent`
+        ✨ Deploying middleware and functions to ${greenBright`Netlify Edge Functions`} ✨
+        This feature is in beta. Please share your feedback here: https://ntl.fyi/next-netlify-edge
+      `)
     }
   },