Skip to content
This repository was archived by the owner on Dec 25, 2024. It is now read-only.

Commit ae3d879

Browse files
committed
v2 refClass simplification (#104)
* Changes modulePath to componentModule * Adds module prefix back into endpoint schema examples * Uses correct property for Schema path analysis * Fixes caching of schemas * Adds package prefix back into model docs * Adds package prefix back into component header docs * Adds package prefix back into component parameter docs * Adds package prefix back into component request body docs * Adds package prefix back into component response docs * Adds refModule back into refClass locations * Fixes discriminator class values * Fixes schema imports * Fixes model imports in schemas init * Moves getImports into defaultcodegen * Removes code to fix imports * Reduces test syntax errors down to 100 * Syntax errors reduced to 62 * Syntax errors reduced to 0 in defaultocegentest * Fixes DefaultCodegenTests * Samples regenerated * Fixes autogen model tests, samples regenerated
1 parent a492a08 commit ae3d879

File tree

830 files changed

+1862
-1537
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

830 files changed

+1862
-1537
lines changed

modules/openapi-json-schema-generator/src/main/java/org/openapitools/codegen/CodegenConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ public interface CodegenConfig {
143143

144144
void setOutputDir(String dir);
145145

146-
CodegenSchema fromSchema(Schema schema, String sourceJsonPath);
146+
CodegenSchema fromSchema(Schema schema, String sourceJsonPath, String currentJsonPath);
147147

148148
CodegenOperation fromOperation(String resourcePath, String httpMethod, Operation operation, List<Server> servers);
149149

modules/openapi-json-schema-generator/src/main/java/org/openapitools/codegen/CodegenHeader.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public class CodegenHeader implements OpenapiComponent {
5353

5454
public Set<String> imports = new HashSet<String>();
5555

56-
protected String modulePath;
56+
protected String componentModule;
5757

5858
public CodegenHeader copy() {
5959
CodegenHeader output = new CodegenHeader();
@@ -82,8 +82,8 @@ public CodegenHeader copy() {
8282
if (this.imports != null) {
8383
output.imports = imports;
8484
}
85-
if (this.modulePath != null) {
86-
output.modulePath = modulePath;
85+
if (this.componentModule != null) {
86+
output.componentModule = componentModule;
8787
}
8888
output.isDeprecated = this.isDeprecated;
8989
output.isExplode = this.isExplode;
@@ -92,17 +92,17 @@ public CodegenHeader copy() {
9292
return output;
9393
}
9494

95-
public String getModulePath() {
96-
return modulePath;
95+
public String getComponentModule() {
96+
return componentModule;
9797
}
9898

99-
public void setModulePath(String modulePath) {
100-
this.modulePath = modulePath;
99+
public void setComponentModule(String componentModule) {
100+
this.componentModule = componentModule;
101101
}
102102

103103
@Override
104104
public int hashCode() {
105-
return Objects.hash(isExplode, paramName, description, unescapedDescription, style, example, jsonSchema, vendorExtensions, isDeprecated, required, hasMultipleTypes, schema, content, ref, refModule, imports, modulePath);
105+
return Objects.hash(isExplode, paramName, description, unescapedDescription, style, example, jsonSchema, vendorExtensions, isDeprecated, required, hasMultipleTypes, schema, content, ref, refModule, imports, componentModule);
106106
}
107107

108108
@Override
@@ -113,7 +113,7 @@ public boolean equals(Object o) {
113113
return isExplode == that.isExplode &&
114114
isDeprecated == that.isDeprecated &&
115115
required == that.required &&
116-
Objects.equals(modulePath, that.modulePath) &&
116+
Objects.equals(componentModule, that.componentModule) &&
117117
Objects.equals(ref, that.getRef()) &&
118118
Objects.equals(imports, that.imports) &&
119119
Objects.equals(refModule, that.getRefModule()) &&
@@ -145,7 +145,7 @@ protected void addInstanceInfo(StringBuilder sb) {
145145
sb.append(", ref=").append(ref);
146146
sb.append(", refModule=").append(refModule);
147147
sb.append(", imports=").append(imports);
148-
sb.append(", modulePath=").append(modulePath);
148+
sb.append(", componentModule=").append(componentModule);
149149
}
150150

151151
@Override

modules/openapi-json-schema-generator/src/main/java/org/openapitools/codegen/CodegenParameter.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,8 @@ public CodegenParameter copy() {
6363
if (this.imports != null) {
6464
output.imports = imports;
6565
}
66-
if (this.modulePath != null) {
67-
output.modulePath = modulePath;
66+
if (this.componentModule != null) {
67+
output.componentModule = componentModule;
6868
}
6969
output.isDeprecated = this.isDeprecated;
7070
output.isExplode = this.isExplode;
@@ -77,7 +77,7 @@ public CodegenParameter copy() {
7777

7878
@Override
7979
public int hashCode() {
80-
return Objects.hash(isFormParam, isQueryParam, isPathParam, isHeaderParam, isCookieParam, isBodyParam, isExplode, baseName, paramName, description, unescapedDescription, style, isDeepObject, isAllowEmptyValue, example, jsonSchema, vendorExtensions, isDeprecated, required, hasMultipleTypes, schema, content, ref, refModule, imports, modulePath);
80+
return Objects.hash(isFormParam, isQueryParam, isPathParam, isHeaderParam, isCookieParam, isBodyParam, isExplode, baseName, paramName, description, unescapedDescription, style, isDeepObject, isAllowEmptyValue, example, jsonSchema, vendorExtensions, isDeprecated, required, hasMultipleTypes, schema, content, ref, refModule, imports, componentModule);
8181
}
8282

8383
@Override

modules/openapi-json-schema-generator/src/main/java/org/openapitools/codegen/CodegenResponse.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,14 @@ public class CodegenResponse implements OpenapiComponent {
3030
private String ref;
3131
public Set<String> imports = new TreeSet<>();
3232
private String refModule;
33-
private String modulePath;
33+
private String componentModule;
3434

3535
@Override
3636
public int hashCode() {
3737
return Objects.hash(message, examples, hasHeaders,
3838
jsonSchema, vendorExtensions,
3939
headers, content,
40-
ref, imports, refModule, modulePath);
40+
ref, imports, refModule, componentModule);
4141
}
4242

4343
@Override
@@ -55,15 +55,15 @@ public boolean equals(Object o) {
5555
Objects.equals(jsonSchema, that.jsonSchema) &&
5656
Objects.equals(vendorExtensions, that.vendorExtensions) &&
5757
Objects.equals(refModule, that.getRefModule()) &&
58-
Objects.equals(modulePath, that.modulePath);
58+
Objects.equals(componentModule, that.componentModule);
5959
}
6060

61-
public String getModulePath() {
62-
return modulePath;
61+
public String getComponentModule() {
62+
return componentModule;
6363
}
6464

65-
public void setModulePath(String modulePath) {
66-
this.modulePath = modulePath;
65+
public void setComponentModule(String componentModule) {
66+
this.componentModule = componentModule;
6767
}
6868

6969
public LinkedHashMap<String, CodegenMediaType> getContent() {
@@ -95,7 +95,7 @@ public String toString() {
9595
sb.append(", ref=").append(ref);
9696
sb.append(", refModule=").append(refModule);
9797
sb.append(", imports=").append(imports);
98-
sb.append(", modulePath=").append(modulePath);
98+
sb.append(", componentModule=").append(componentModule);
9999
sb.append('}');
100100
return sb.toString();
101101
}

modules/openapi-json-schema-generator/src/main/java/org/openapitools/codegen/CodegenSchema.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@
2121

2222
import java.util.*;
2323

24-
public class CodegenSchema implements JsonSchema {
24+
public class CodegenSchema implements JsonSchema, OpenapiComponent {
2525
// testCases are for autogenerated tests of schemas
2626
public HashMap<String, SchemaTestCase> testCases = new HashMap<>();
27-
private String modulePath;
27+
private String componentModule;
2828
public TreeSet<String> imports;
2929
private ExternalDocumentation externalDocumentation;
3030
public String refClass;
@@ -165,12 +165,12 @@ public class CodegenSchema implements JsonSchema {
165165
private CodegenSchema contains;
166166
public CodegenDiscriminator discriminator;
167167

168-
public String getModulePath() {
169-
return modulePath;
168+
public String getComponentModule() {
169+
return componentModule;
170170
}
171171

172-
public void setModulePath(String modulePath) {
173-
this.modulePath = modulePath;
172+
public void setComponentModule(String componentModule) {
173+
this.componentModule = componentModule;
174174
}
175175

176176
public Set<String> getImports() {
@@ -826,7 +826,7 @@ protected void addInstanceInfo(StringBuilder sb) {
826826
sb.append(", externalDocumentation=").append(externalDocumentation);
827827
sb.append(", discriminator=").append(discriminator);
828828
sb.append(", imports=").append(imports);
829-
sb.append(", modulePath=").append(modulePath);
829+
sb.append(", componentModule=").append(componentModule);
830830
sb.append(", testCases=").append(testCases);
831831
}
832832
@Override
@@ -883,7 +883,7 @@ public boolean equals(Object o) {
883883
isBooleanSchemaFalse == that.getIsBooleanSchemaFalse() &&
884884
getSchemaIsFromAdditionalProperties() == that.getSchemaIsFromAdditionalProperties() &&
885885
Objects.equals(testCases, that.testCases) &&
886-
Objects.equals(modulePath, that.getModulePath()) &&
886+
Objects.equals(componentModule, that.getComponentModule()) &&
887887
Objects.equals(imports, that.getImports()) &&
888888
Objects.equals(discriminator, that.getDiscriminator()) &&
889889
Objects.equals(externalDocumentation, that.getExternalDocumentation()) &&
@@ -945,6 +945,6 @@ public int hashCode() {
945945
ref, schemaIsFromAdditionalProperties, isBooleanSchemaTrue, isBooleanSchemaFalse,
946946
format, dependentRequired, contains, refModule, allOf, anyOf, oneOf, not,
947947
properties, optionalProperties, requiredProperties, externalDocumentation,
948-
discriminator, imports, modulePath, testCases);
948+
discriminator, imports, componentModule, testCases);
949949
}
950950
}

0 commit comments

Comments
 (0)