Skip to content
This repository was archived by the owner on Dec 25, 2024. It is now read-only.

Commit 22fcdcc

Browse files
authored
Fixes model import when packageName has periods (#75)
1 parent d6a611b commit 22fcdcc

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

modules/openapi-json-schema-generator/src/main/java/org/openapitools/codegen/languages/PythonClientCodegen.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -889,7 +889,7 @@ public String toDefaultValue(Schema p) {
889889
@Override
890890
public String toModelImport(String name) {
891891
// name looks like Cat
892-
return "from " + packagePath() + "." + modelPackage() + "." + toModelFilename(name) + " import " + toModelName(name);
892+
return "from " + packageName + "." + modelPackage() + "." + toModelFilename(name) + " import " + toModelName(name);
893893
}
894894

895895
@Override

modules/openapi-json-schema-generator/src/test/java/org/openapitools/codegen/python/PythonClientTest.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -224,4 +224,13 @@ public void testEnumNames() {
224224
Assert.assertEquals(enumVars.get(0).get("name"), "DIGIT_THREE_67B9C");
225225
Assert.assertEquals(enumVars.get(1).get("name"), "FFA5A4");
226226
}
227+
228+
@Test(description = "format imports of models using a package containing dots")
229+
public void testImportWithQualifiedPackageName() throws Exception {
230+
final PythonClientCodegen codegen = new PythonClientCodegen();
231+
codegen.setPackageName("openapi.client");
232+
233+
String importValue = codegen.toModelImport("model_name");
234+
Assert.assertEquals(importValue, "from openapi.client.model.model_name import ModelName");
235+
}
227236
}

0 commit comments

Comments
 (0)