From d482b2c218725def88b33688996902ec48985ed0 Mon Sep 17 00:00:00 2001 From: Dor Cohen Date: Fri, 12 Jul 2024 21:17:56 -0400 Subject: [PATCH 1/3] fix: add missing import to model template --- .gitignore | 3 +++ openapi_python_client/templates/model.py.jinja | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 5689da19b..b04b9f514 100644 --- a/.gitignore +++ b/.gitignore @@ -24,6 +24,9 @@ dmypy.json # JetBrains .idea/ +# Visual Studio Code +.vscode/ + test-reports/ /coverage.xml diff --git a/openapi_python_client/templates/model.py.jinja b/openapi_python_client/templates/model.py.jinja index 44f5bf148..d15b010ad 100644 --- a/openapi_python_client/templates/model.py.jinja +++ b/openapi_python_client/templates/model.py.jinja @@ -1,4 +1,4 @@ -from typing import Any, Dict, Type, TypeVar, Tuple, Optional, BinaryIO, TextIO, TYPE_CHECKING +from typing import Any, cast, Dict, Type, TypeVar, Tuple, Optional, BinaryIO, TextIO, TYPE_CHECKING {% if model.additional_properties %} from typing import List From fa7a00395432cd3c8eba96cf7e0b0bac05b682f6 Mon Sep 17 00:00:00 2001 From: Dylan Anthony Date: Sun, 25 Aug 2024 00:19:18 -0600 Subject: [PATCH 2/3] Move new import into `ConstProperty` --- openapi_python_client/parser/properties/const.py | 2 +- openapi_python_client/templates/model.py.jinja | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/openapi_python_client/parser/properties/const.py b/openapi_python_client/parser/properties/const.py index aec624afd..f5fb7a493 100644 --- a/openapi_python_client/parser/properties/const.py +++ b/openapi_python_client/parser/properties/const.py @@ -115,6 +115,6 @@ def get_imports(self, *, prefix: str) -> set[str]: if self.required: return {"from typing import Literal"} return { - "from typing import Literal, Union", + "from typing import Literal, Union, cast", f"from {prefix}types import UNSET, Unset", } diff --git a/openapi_python_client/templates/model.py.jinja b/openapi_python_client/templates/model.py.jinja index d15b010ad..44f5bf148 100644 --- a/openapi_python_client/templates/model.py.jinja +++ b/openapi_python_client/templates/model.py.jinja @@ -1,4 +1,4 @@ -from typing import Any, cast, Dict, Type, TypeVar, Tuple, Optional, BinaryIO, TextIO, TYPE_CHECKING +from typing import Any, Dict, Type, TypeVar, Tuple, Optional, BinaryIO, TextIO, TYPE_CHECKING {% if model.additional_properties %} from typing import List From 2caad3e78acb351ea802fe0eb6f9d35f85b313e3 Mon Sep 17 00:00:00 2001 From: Dylan Anthony Date: Sun, 25 Aug 2024 00:20:14 -0600 Subject: [PATCH 3/3] Add changeset --- .changeset/add_missing_cast_import_when_using_const.md | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 .changeset/add_missing_cast_import_when_using_const.md diff --git a/.changeset/add_missing_cast_import_when_using_const.md b/.changeset/add_missing_cast_import_when_using_const.md new file mode 100644 index 000000000..b342da747 --- /dev/null +++ b/.changeset/add_missing_cast_import_when_using_const.md @@ -0,0 +1,7 @@ +--- +default: patch +--- + +# Add missing `cast` import when using `const` + +Fixed by PR #1072. Thanks @dorcohe!