Skip to content

fix(client): trim '/' and empty character in base URL #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2025

Conversation

mssfang
Copy link
Contributor

@mssfang mssfang commented Apr 8, 2025

fix a bug where the base URL was not trimmed properly.

fixes: #423

FYI @jpalvarezl

@mssfang mssfang marked this pull request as ready for review April 8, 2025 22:08
@mssfang mssfang requested a review from a team as a code owner April 8, 2025 22:08
@TomerAberbach
Copy link
Collaborator

I'm fixing next btw so your CI should pass after I do

@TomerAberbach
Copy link
Collaborator

Mind rebasing onto latest next? Should be fixed now

@TomerAberbach TomerAberbach merged commit 37370df into openai:next Apr 8, 2025
2 of 3 checks passed
@stainless-app stainless-app bot mentioned this pull request Apr 8, 2025
stainless-app bot pushed a commit that referenced this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants